From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28818 invoked by alias); 11 Apr 2013 13:22:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28803 invoked by uid 89); 11 Apr 2013 13:22:24 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 13:22:24 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UQHSI-0000n5-Ki from Hafiz_Abid@mentor.com for gdb-patches@sourceware.org; Thu, 11 Apr 2013 06:22:22 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 11 Apr 2013 06:22:22 -0700 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server (TLS) id 14.1.289.1; Thu, 11 Apr 2013 14:22:20 +0100 Date: Thu, 11 Apr 2013 22:59:00 -0000 From: "Abid, Hafiz" Subject: Re: [patch] circ.exp To: References: <1363803795.2570.4@abidh-ubunto1104> In-Reply-To: <1363803795.2570.4@abidh-ubunto1104> (from hafiz_abid@mentor.com on Wed Mar 20 18:23:15 2013) Message-ID: <1365686537.9625.1@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-04/txt/msg00331.txt.bz2 Ping. Original post at http://sourceware.org/ml/gdb-patches/2013-03/msg00760.html On 20/03/13 18:23:15, Abid, Hafiz wrote: > Hi All, > This is patch to refactor circ.exp. I noticed that it was quitting=20=20 > early as gdb_target_supports_trace was failing. There were some=20=20 > other issues too. After the changes, it is running to completion.=20=20= =20 > How does it look? >=20 > One test is failing that probably shows a defect. Following session,=20= =20 > which is edited for clarity, shows the problem. When there is not=20=20 > enough buffer left (3rd frame onward), target does not stop the=20=20 > trace. It continues but only uses 6 bytes for the frame. >=20 > (gdb) set trace-buffer-size 200 > (gdb) tstart > (gdb) c > ... > (gdb) tstatus > Collected 1 trace frames. > Trace buffer has 131 bytes of 200 bytes free (34% full). > ... > (gdb) c > ... > (gdb) tstatus > Collected 2 trace frames. > Trace buffer has 62 bytes of 200 bytes free (69% full). > ... > (gdb) c > ... > (gdb) tstatus > Trace is running on the target. > Collected 3 trace frames. > Trace buffer has 56 bytes of 200 bytes free (72% full). > ... > (gdb) c > ... > (gdb) tstatus > Collected 4 trace frames. > Trace buffer has 50 bytes of 200 bytes free (75% full). > ... > (gdb) c > ... > (gdb) tstatus > Collected 5 trace frames. > Trace buffer has 44 bytes of 200 bytes free (78% full). > ... > (gdb) tstop > (gdb) tfind start > Found trace frame 0, tracepoint 11 > #0 func0 () at ../.././../git/gdb/testsuite/gdb.trace/circ.c:11 > 11 } > (gdb) p testload > $4 =3D {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13} > (gdb) tfind 4 > Found trace frame 4, tracepoint 5 > 27 } > (gdb) p testload > $5 =3D { } >=20 >=20 > Regards, > Abid >=20 > gdb/testsuite: >=20 > 2013-03-20 Hafiz Abid Qadeer >=20 > * gdb.trace/circ.exp: (run_trace_experiment): Test > setup_tracepoints and 'break end' in it. > (trace_buffer_normal): Refactor it to... > (support_trace_packet). ..this. > (gdb_trace_circular_tests): Remove. Move tests to... > (top level): ... here. Call 'runto_main' before checking for > trace support. Call 'support_trace_packets' to check the > support for QTBuffer:size and QTBuffer:circular.