Re: [PATCH 5/7] range stepping: New command 'maint set range stepping'

Eli Zaretskii
2013-03-11T17:05:13Z

> From: Yao Qi <yao@codesourcery.com>
> Date: Mon, 11 Mar 2013 20:51:29 +0800
>
> +@kindex maint set range-stepping
> +@kindex maint show range-stepping
> +@cindex range-stepping
> +@item maint set range-stepping
> +@itemx maint show range-stepping
> +Control whether to do stepping in an address range.

Why is this a maintenance command?

Anyway, the documentation part is OK.

> + add_setshow_boolean_cmd ("range-stepping", class_maintenance,
> + &use_range_stepping, _("\
> +Enable or disable range-stepping."), _("\
> +Show whether range-stepping is enabled."), _("\
> +If On, GDB will tell the target to do stepping a range of address.\n\

I suggest

If ON, GDB will send a single packet to a target telling it to keep
single-stepping as long as PC is inside a certain range of addresses.

> +This will speed up stepping a line of source file.\n\
> +If off, GDB will not use it, even if such is supported by the \n\

"will not use this feature". "It" is ambiguous here.

Thanks.