From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8404 invoked by alias); 8 Mar 2013 14:27:32 -0000 Received: (qmail 8379 invoked by uid 22791); 8 Mar 2013 14:27:30 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_QT X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 14:27:00 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UDyGB-0001kg-KU from Hafiz_Abid@mentor.com ; Fri, 08 Mar 2013 06:26:59 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 8 Mar 2013 06:26:59 -0800 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.1.289.1; Fri, 8 Mar 2013 14:26:57 +0000 Date: Fri, 08 Mar 2013 14:27:00 -0000 From: "Abid, Hafiz" Subject: Re: [patch] Change trace buffer size(v5) To: Eli Zaretskii CC: , , , References: <1362742183.28338.0@abidh-ubunto1104> <83fw06yof8.fsf@gnu.org> In-Reply-To: <83fw06yof8.fsf@gnu.org> (from eliz@gnu.org on Fri Mar 8 14:08:27 2013) Message-ID: <1362752816.30327.0@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00368.txt.bz2 On 08/03/13 14:08:27, Eli Zaretskii wrote: > > Date: Fri, 8 Mar 2013 11:29:43 +0000 > > From: "Abid, Hafiz" > > CC: , , > > , > > > > gdb/ > > * NEWS: Mention set and show trace-buffer-size commands. > > Mention new packet. > > * target.h (struct target_ops): New method > > to_set_trace_buffer_size. > > (target_set_trace_buffer_size): New macro. > > * target.c (update_current_target): Set up new method. > > * tracepoint.c (trace_buffer_size): New global. > > (start_tracing): Send it to the target. > > (set_trace_buffer_size): New function. > > (_initialize_tracepoint): Add new setshow for trace-buffer-size. > > * remote.c (remote_set_trace_buffer_size): New function. > > (_initialize_remote): Use it. > > (QTBuffer:size) New remote command. > > (PACKET_QTBuffer_size): New enum. > > (remote_protocol_features): Add an entry for > > PACKET_QTBuffer_size. > > > > gdb/gdbserver/ > > * tracepoint.c (trace_buffer_size): New global. > > (DEFAULT_TRACE_BUFFER_SIZE): New define. > > (init_trace_buffer): Change to one-argument function. Allocate > > trace buffer memory. > > (handle_tracepoint_general_set): Call cmd_bigqtbuffer_size to > > handle QTBuffer:size packet. > > (cmd_bigqtbuffer_size): New function. > > (initialize_tracepoint): Call init_trace_buffer with > > DEFAULT_TRACE_BUFFER_SIZE. > > * server.c (handle_query): Add QTBuffer:size in the > > supported packets. > > > > gdb/doc/ > > * gdb.texinfo (Starting and Stopping Trace Experiments): > > Document > > trace-buffer-size set and show commands. > > (Tracepoint Packets): Document QTBuffer:size. > > (General Query Packets): Document QTBuffer:size. > > > > gdb/testsuite/ > > * gdb.trace/trace-buffer-size.exp: New file. > > * gdb.trace/trace-buffer-size.c: New file. >=20 > I already approved the documentation parts of this, didn't I? >=20 Yes. Although some additions were done after that as suggested by Pedro.