Re: [patch] Change trace buffer size(v5)

Pedro Alves
2013-05-03T15:26:52Z

On 05/03/2013 04:08 PM, Abid, Hafiz wrote:

> I have attached a patch. It calls 'stop_tracing' from the QTinit handler. I was wondering that setting 'tracing' to 0 may be enough. But stop_tracing seems to do a lot of other things which may be required. So I thought it is better to go with it.

Right.

> Another possibility is to let QTBuffer:size handler return ok if the new size is equal to current size irrespective of the value of 'tracing'.

I'd rather not add special cases.

> As I mentioned earlier, a testcase was already present for this scenario but
> it was missing the error message that came after we press 'y'. I have handled
> it but would like to know if there is a better way to do it.

Looks like a good solution.

> proc test_tstart_tstart { } {
> with_test_prefix "tstart_tstart" {
> + global gdb_prompt
> global executable
> global hex

This looks unnecessary. Otherwise OK for mainline and 7.6.

Thanks!

--
Pedro Alves