Re: [patch] Change trace buffer size(v5)

Abid, Hafiz
2013-03-08T15:15:09Z

Hi Yao,
Sorry, I had already applied the patch before I saw your email.

> Minor suggestion, if they can fit in one line, better to write them
> in one line. The first backslash is not necessary. Here and
> somewhere else. We can write them in two lines:
>
> gdb_test_no_output "set trace-buffer-size $BUFFER_SIZE" \
> "set trace buffer size 1"
I will keep this in mind for future work.

>> Document
>> trace-buffer-size set and show commands.
>
> The indentation looks odd here.
>
>> + set_trace_buffer_size, NULL,
>> + &setlist, &showlist);
>> +
>
> Indentation looks odd to me.

If you can let me know which portion is wrong then it will help me.

Thanks,
Abid