Re: [patch] Change trace buffer size

Pedro Alves
2013-02-27T16:55:24Z

On 02/19/2013 02:51 AM, Yao Qi wrote:
>>
>
> We may mention the new remote packet in NEWS.

Indeed. s/may/should/.

>>
>> @@ -912,6 +913,9 @@ update_current_target (void)
>> de_fault (to_set_circular_trace_buffer,
>> (void (*) (int))
>> target_ignore);
>> + de_fault (to_set_trace_buffer_size,
>> + (void (*) (LONGEST))
>> + target_ignore);
>
> I am wondering 'tcomplain' may be better than 'target_ignore'.

I think it's better to have the command behave the
same as the other related "set circular-trace-buffer"
set disconnected-tracing. We've discussed this behavior in
the context of the patch that adds one of these other
commands (or both?).
Do you see a reason this command should behave different?
tcomplain would trigger if you used the "set ..." command
before being connected to any target (or after disconnecting).

--
Pedro Alves