Re: [patch] Change trace buffer size(v5)

Eli Zaretskii
2013-03-09T11:07:37Z

> From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Sat, 9 Mar 2013 10:20:12 +0000
>
> I am committing the patch below to fix the build. I think it counts as obvious. Please let me know if there is any problem. Sorry for the inconvenience.
>
> Thanks,
> Abid
>
> 2012-03-09 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> gdb/doc/
> * gdb.texinfo (QTBuffer:size): Add cindex and anchor.
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index f0caef1..ba03fca 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -38479,6 +38479,8 @@ This packet directs the target to use a circular trace buffer if
> @var{value} is 1, or a linear buffer if the value is 0.
>
> @item QTBuffer:size:@var{size}
> +@anchor{QTBuffer:size}
> +@cindex @samp{QTBuffer:size} packet

Sorry, but this isn't right. You cannot have colons in @anchor or in
@cindex entries, because that will confuse Info readers when they try
to deduce the referenced spot. (This is explained in the Texinfo
manual, in the nodes "Node Line Requirements", "@anchor", and
"Indexing Commands".)

Fixed thusly:

2013-03-09 Eli Zaretskii <eliz@gnu.org>

* gdb.texinfo (General Query Packets, Tracepoint Packets): Don't
use colons in @anchor and @cindex entries.

Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.1056
retrieving revision 1.1057
diff -u -r1.1056 -r1.1057
--- gdb/doc/gdb.texinfo 9 Mar 2013 10:21:42 -0000 1.1056
+++ gdb/doc/gdb.texinfo 9 Mar 2013 11:01:00 -0000 1.1057
@@ -37552,7 +37552,7 @@
to be enabled and disabled while a trace experiment is running.

@item QTBuffer:size
-The remote stub supports the @samp{QTBuffer:size} (@pxref{QTBuffer:size})
+The remote stub supports the @samp{QTBuffer:size} (@pxref{QTBuffer-size})
packet that allows to change the size of the trace buffer.

@item tracenz
@@ -38479,8 +38479,8 @@
@var{value} is 1, or a linear buffer if the value is 0.

@item QTBuffer:size:@var{size}
-@anchor{QTBuffer:size}
-@cindex @samp{QTBuffer:size} packet
+@anchor{QTBuffer-size}
+@cindex @samp{QTBuffer size} packet
This packet directs the target to make the trace buffer be of size
@var{size} if possible. A value of @code{-1} tells the target to
use whatever size it prefers.