RE: [patch] Change trace buffer size(v5)

Abid, Hafiz
2013-03-09T10:20:27Z

________________________________________
From: Eli Zaretskii [eliz@gnu.org]
Sent: Saturday, March 09, 2013 8:27 AM
To: Joel Brobecker
Cc: Abid, Hafiz; gdb-patches@sourceware.org
Subject: Re: [patch] Change trace buffer size(v5)

> Date: Fri, 8 Mar 2013 21:06:26 -0500
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> > +@item QTBuffer:size
> > +The remote stub supports the @samp{QTBuffer:size} (@pxref{QTBuffer:size})
> > +packet that allows to change the size of the trace buffer.
>
> This causes the documenation to fail, which also affect the nightly
> packaging of the sources:
>
> ./gdb.texinfo:37555: Cross reference to nonexistent node `QTBuffer:size' (perhaps incorrect sectioning?).

>I sincerely hope no one is committing changes to the manuals without
>saying "make" in the gdb/doc directory first.

Joel, Eli,
I am committing the patch below to fix the build. I think it counts as obvious. Please let me know if there is any problem. Sorry for the inconvenience.

Thanks,
Abid

2012-03-09 Hafiz Abid Qadeer <abidh@codesourcery.com>

gdb/doc/
* gdb.texinfo (QTBuffer:size): Add cindex and anchor.

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index f0caef1..ba03fca 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -38479,6 +38479,8 @@ This packet directs the target to use a circular trace buffer if
@var{value} is 1, or a linear buffer if the value is 0.

@item QTBuffer:size:@var{size}
+@anchor{QTBuffer:size}
+@cindex @samp{QTBuffer:size} packet
This packet directs the target to make the trace buffer be of size
@var{size} if possible. A value of @code{-1} tells the target to
use whatever size it prefers.