Re: [patch] Change trace buffer size(v5)

Eli Zaretskii
2013-03-08T14:09:07Z

> Date: Fri, 8 Mar 2013 11:29:43 +0000
> From: "Abid, Hafiz" <hafiz_abid@mentor.com>
> CC: <gdb-patches@sourceware.org>, <stan@codesourcery.com>,
> <yao@codesourcery.com>, <eliz@gnu.org>
>
> gdb/
> * NEWS: Mention set and show trace-buffer-size commands.
> Mention new packet.
> * target.h (struct target_ops): New method
> to_set_trace_buffer_size.
> (target_set_trace_buffer_size): New macro.
> * target.c (update_current_target): Set up new method.
> * tracepoint.c (trace_buffer_size): New global.
> (start_tracing): Send it to the target.
> (set_trace_buffer_size): New function.
> (_initialize_tracepoint): Add new setshow for trace-buffer-size.
> * remote.c (remote_set_trace_buffer_size): New function.
> (_initialize_remote): Use it.
> (QTBuffer:size) New remote command.
> (PACKET_QTBuffer_size): New enum.
> (remote_protocol_features): Add an entry for
> PACKET_QTBuffer_size.
>
> gdb/gdbserver/
> * tracepoint.c (trace_buffer_size): New global.
> (DEFAULT_TRACE_BUFFER_SIZE): New define.
> (init_trace_buffer): Change to one-argument function. Allocate
> trace buffer memory.
> (handle_tracepoint_general_set): Call cmd_bigqtbuffer_size to
> handle QTBuffer:size packet.
> (cmd_bigqtbuffer_size): New function.
> (initialize_tracepoint): Call init_trace_buffer with
> DEFAULT_TRACE_BUFFER_SIZE.
> * server.c (handle_query): Add QTBuffer:size in the
> supported packets.
>
> gdb/doc/
> * gdb.texinfo (Starting and Stopping Trace Experiments):
> Document
> trace-buffer-size set and show commands.
> (Tracepoint Packets): Document QTBuffer:size.
> (General Query Packets): Document QTBuffer:size.
>
> gdb/testsuite/
> * gdb.trace/trace-buffer-size.exp: New file.
> * gdb.trace/trace-buffer-size.c: New file.

I already approved the documentation parts of this, didn't I?