Re: [patch v9 23/23] btrace, remote: drop qbtrace packet

Eli Zaretskii
2013-03-04T18:15:25Z

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com,
> Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 4 Mar 2013 18:06:10 +0100
>
> Use the qXfer:btrace:read packet's annex to encode a trace read method:
>
> all ... read all trace
> new ... read all trace if the trace has changed
>
> This obsoletes the need for the qbtrace packet.
>
> CC: Pedro Alves <palves@redhat.com>
> CC: Jan Kratochvil <jan.kratochvil@redhat.com>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> 2013-03-04 Markus Metzger <markus.t.metzger@intel.com>
>
> * target.h (target_ops) <to_read_btrace>: Add type parameter.
> (target_ops) <to_btrace_has_changed>: Remove.
> (target_btrace_has_changed): Remove.
> (target_read_btrace): Add type parameter.
> * target.c (target_read_btrace): Add type parameter.
> (target_btrace_has_changed): Remove.
> * remote.c (PACKET_qbtrace): Remove.
> (remote_protocol_features): Remove qbtrace.
> (remote_supports_btrace): Remove check for qbtrace.
> (remote_btrace_has_changed): Remove.
> (remote_read_btrace): Consider read type.
> (init_remote_ops): Remove to_disable_btrace.
> (_initialize_remote): Remove qbtrace.
> * i386-linux-nat.c (_initialize_i386_linux_nat): Remove
> initialization of to_btrace_has_changed.
> * common/linux-btrace.h (linux_read_btrace): Add type parameter.
> (linux_btrace_has_changed): Removed.
> * common/linux-btrace.c (linux_btrace_has_changed): Moved.
> Changed to static.
> (linux_read_btrace): Consider read type.
> * common/btrace-common.h (btrace_read_type): New enum.
> * btrace.c (btrace_fetch): Only update branch trace if it
> changed.
> * amd64-linux-nat.c (_initialize_amd64_linux_nat): Remove
> initialization of to_btrace_has_changed.
>
> gdbserver/
>
> * target.h (target_ops): Remove btrace_has_changed. Add type
> parameter to read_btrace. Update target_ macros.
> * server.c: Include btrace-common.h.
> (handle_qxfer_btrace): Consider read type in annex.
> (handle_btrace_query): Removed.
> (handle_query): Remove qbtrace from qSupported. Remove call to
> handle_btrace_query.
> * linux-low.c (linux_low_read_btrace): Consider read type.
> (linux_target_ops): Remove linux_btrace_has_changed.
>
> doc/
>
> * gdb.texinfo (Remote Configuration): Remove qbtrace.
> Describe annex of Qbtrace.

OK for the documentation part.

Thanks.