From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 2/2] use zuinteger_unlimited for heuristic-fence-post
Date: Fri, 15 Feb 2013 13:29:00 -0000 [thread overview]
Message-ID: <1360934868-5807-3-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1360934868-5807-1-git-send-email-yao@codesourcery.com>
Hi,
The comment here gives me a feeling that we should convert this
command to zuinteger_unlimited_cmd.
gdb:
2013-02-15 Yao Qi <yao@codesourcery.com>
* alpha-tdep.c (_initialize_alpha_tdep): Call
add_setshow_zuinteger_unlimited_cmd instead of
add_setshow_zinteger_cmd.
Remove comments.
* mips-tdep.c (_initialize_mips_tdep): Likewise.
---
gdb/alpha-tdep.c | 16 +++++++---------
gdb/mips-tdep.c | 16 +++++++---------
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c
index e394605..1a6ceb7 100644
--- a/gdb/alpha-tdep.c
+++ b/gdb/alpha-tdep.c
@@ -1872,20 +1872,18 @@ _initialize_alpha_tdep (void)
/* Let the user set the fence post for heuristic_proc_start. */
- /* We really would like to have both "0" and "unlimited" work, but
- command.c doesn't deal with that. So make it a var_zinteger
- because the user can always use "999999" or some such for unlimited. */
/* We need to throw away the frame cache when we set this, since it
might change our ability to get backtraces. */
- add_setshow_zinteger_cmd ("heuristic-fence-post", class_support,
- &heuristic_fence_post, _("\
+ add_setshow_zuinteger_unlimited_cmd ("heuristic-fence-post", class_support,
+ &heuristic_fence_post, _("\
Set the distance searched for the start of a function."), _("\
Show the distance searched for the start of a function."), _("\
If you are debugging a stripped executable, GDB needs to search through the\n\
program for the start of a function. This command sets the distance of the\n\
search. The only need to set it is when debugging a stripped executable."),
- reinit_frame_cache_sfunc,
- NULL, /* FIXME: i18n: The distance searched for
- the start of a function is \"%d\". */
- &setlist, &showlist);
+ reinit_frame_cache_sfunc,
+ NULL, /* FIXME: i18n: The distance
+ searched for the start of a
+ function is \"%d\". */
+ &setlist, &showlist);
}
diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index c7684f8..12bb8ab 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -8884,20 +8884,18 @@ and is updated automatically from ELF file flags if available."),
_("Show current use of MIPS floating-point coprocessor target."),
&showlist);
- /* We really would like to have both "0" and "unlimited" work, but
- command.c doesn't deal with that. So make it a var_zinteger
- because the user can always use "999999" or some such for unlimited. */
- add_setshow_zinteger_cmd ("heuristic-fence-post", class_support,
- &heuristic_fence_post, _("\
+ add_setshow_zuinteger_unlimited_cmd ("heuristic-fence-post", class_support,
+ &heuristic_fence_post, _("\
Set the distance searched for the start of a function."), _("\
Show the distance searched for the start of a function."), _("\
If you are debugging a stripped executable, GDB needs to search through the\n\
program for the start of a function. This command sets the distance of the\n\
search. The only need to set it is when debugging a stripped executable."),
- reinit_frame_cache_sfunc,
- NULL, /* FIXME: i18n: The distance searched for
- the start of a function is %s. */
- &setlist, &showlist);
+ reinit_frame_cache_sfunc,
+ NULL, /* FIXME: i18n: The distance
+ searched for the start of a
+ function is %s. */
+ &setlist, &showlist);
/* Allow the user to control whether the upper bits of 64-bit
addresses should be zeroed. */
--
1.7.7.6
next prev parent reply other threads:[~2013-02-15 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 13:29 [PATCH 0/2] Use zuinteger_unlimited Yao Qi
2013-02-15 13:29 ` Yao Qi [this message]
2013-02-15 13:29 ` [PATCH 1/2] use zuinteger_unlimited for some remote commands Yao Qi
2013-03-04 13:19 ` Pedro Alves
2013-03-04 14:38 ` Yao Qi
2013-03-04 16:21 ` Pedro Alves
2013-03-05 7:45 ` Yao Qi
2013-03-05 12:59 ` Pedro Alves
2013-03-05 17:33 ` Doug Evans
2013-03-05 18:07 ` Pedro Alves
2013-03-06 0:30 ` Doug Evans
2013-02-25 3:15 ` ping : [PATCH 0/2] Use zuinteger_unlimited Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360934868-5807-3-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox