From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32032 invoked by alias); 24 Jan 2013 13:11:34 -0000 Received: (qmail 31928 invoked by uid 22791); 24 Jan 2013 13:11:33 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jan 2013 13:11:20 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Jan 2013 11:11:18 -0200 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp04.br.ibm.com (10.172.0.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 24 Jan 2013 11:11:17 -0200 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 619B13520054 for ; Thu, 24 Jan 2013 08:11:16 -0500 (EST) Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0ODAlZl24903730 for ; Thu, 24 Jan 2013 11:10:47 -0200 Received: from d24av03.br.ibm.com (loopback [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0OBBc5A029679 for ; Thu, 24 Jan 2013 09:11:38 -0200 Received: from [9.8.12.62] ([9.8.12.62]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r0OBBcED029660 for ; Thu, 24 Jan 2013 09:11:38 -0200 Message-ID: <1359033075.28026.68.camel@localhost.localdomain> Subject: Re: [PATCH] Fix handling of #include files during prologue skipping From: Tiago =?ISO-8859-1?Q?St=FCrmer?= Daitx To: gdb-patches@sourceware.org Date: Thu, 24 Jan 2013 13:11:00 -0000 In-Reply-To: <201301241256.r0OCueFI023763@d06av02.portsmouth.uk.ibm.com> References: <201301241256.r0OCueFI023763@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13012413-8936-0000-0000-00000926F315 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00589.txt.bz2 Yes, it still shows up. Sorry, should have added this information before. Without patch: $ gdb prologue-include (gdb) break main Breakpoint 1 at 0x10000594: file prologue-include.h, line 19. With patch applied: $ gdb prologue-include (gdb) break main Breakpoint 1 at 0x1000058c: file prologue-include.h, line 18. -- Tiago Stürmer Daitx tdaitx@linux.vnet.ibm.com IBM - Linux Technology Center On Thu, 2013-01-24 at 13:56 +0100, Ulrich Weigand wrote: > Tiago Daitx wrote: > > > I didn't include one since the header files in gdb.base that I looked at > > the time didn't have it. I checked it again and noticed that from all 11 > > headers files in there only 1 has a copyright in it > > (gdb.base/included.h). > > > > If a copyright is actually needed I will be happy to include one, so > > please let me know your answer. > > If you do so, please keep in mind that the bug the test case triggered > depends on (relative) line number values, so please make sure the bug > actually still shows (with unpatched GDB) after you've added the > comment lines ... > > Bye, > Ulrich >