From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31971 invoked by alias); 8 Jan 2013 18:42:41 -0000 Received: (qmail 31930 invoked by uid 22791); 8 Jan 2013 18:42:41 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Jan 2013 18:42:35 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 9198233DA8E; Tue, 8 Jan 2013 18:42:34 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Cc: hjl.tools@gmail.com, jan.kratochvil@redhat.com Subject: [PATCH v2] gdb: x86: fix x32 builds with inline asm Date: Tue, 08 Jan 2013 18:42:00 -0000 Message-Id: <1357670699-17485-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1357657280-24150-1-git-send-email-vapier@gentoo.org> References: <1357657280-24150-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00144.txt.bz2 We need to cast the pointer up to 64bits so that the push works on x32 targets. For 64bit targets, this makes no difference. Signed-off-by: Mike Frysinger 2012-01-08 Mike Frysinger * common/linux-ptrace.c (linux_ptrace_test_ret_to_nx) [__x86_64__]: Cast return_address to 64bits. --- v2 - just cast the value in the x86_64 path to fix x32 builds gdb/common/linux-ptrace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/common/linux-ptrace.c b/gdb/common/linux-ptrace.c index 761ef59..886be80 100644 --- a/gdb/common/linux-ptrace.c +++ b/gdb/common/linux-ptrace.c @@ -114,7 +114,8 @@ linux_ptrace_test_ret_to_nx (void) ".globl linux_ptrace_test_ret_to_nx_instr;" "linux_ptrace_test_ret_to_nx_instr:" "ret" - : : "r" (return_address) : "%rsp", "memory"); + : : "r" ((uint64_t) (uintptr_t) return_address) + : "%rsp", "memory"); #else # error "!__i386__ && !__x86_64__" #endif -- 1.8.0.2