RE: [patch v5 07/12] btrace, doc: document remote serial protocol

Metzger, Markus T
2012-12-14T07:53:19Z

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, December 13, 2012 6:09 PM
> To: Metzger, Markus T
> Cc: Eli Zaretskii; gdb-patches@sourceware.org; jan.kratochvil@redhat.com; palves@redhat.com; tromey@redhat.com;
> kettenis@gnu.org
> Subject: Re: [patch v5 07/12] btrace, doc: document remote serial protocol
>
> On 12/13/2012 08:43 AM, Metzger, Markus T wrote:
>
> > I will keep the patch in the series until the entire series has been approved. Do you want me to omit this patch when sending out
> updates of the series?
>
> Please keep it in the series. The mechanics of the docs might be
> approved, but someone should still go over the packet's semantics,
> and its just to easier on someone looking at the whole thing
> if things are kept together, instead of having the reader hunt
> for bits and pieces.

OK, I'll keep sending this patch and add a note to the cover letter that rsp doc has been approved.

Are you OK with the changes I made in response to your feedback, Pedro? I will also address the explicit == NULL and != NULL checks in the next update. Is there anything else that needs changing?

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052