RE: [patch v5 02/12] cli, btrace: add btrace cli

Metzger, Markus T
2012-12-13T09:14:30Z

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Eli Zaretskii
> Sent: Friday, December 07, 2012 4:16 PM

Thanks for your review.

[...]

> > Add branch trace commands:
>
> Thanks. This will be documented at some point, yes?

Yes. I will start it shortly.

> > + add_cmd ("list", class_btrace, cmd_btrace_list, _("\
> > +List branch trace blocks.\n\n\
> > +Prints a list of all blocks for which branch trace is available.\n\
>
> "Print", not "prints", to be compatible with "List".

Fixed.

> > +With a /a modifier, addresses are included.\n\
> > +With a /f modifier, the function name is included (if available).\n\
>
> It is better to use active tense, not passive tense:
>
> With a /a modifier, include addresses.
> With a /f modifier, include function names (if available).

I changed this for all command texts.

> > +With a /l modifier, source lines are include (if available).\n\
> ^^^^^^^
> A typo.

Changed to active tense.

> > +With a /t modifier, prints the total number of trace blocks and stops.\n\
> ^^^^^^
> "print"

Fixed. Everywhere.

> > +Without any modifier, behaves as if /fl were specified.\n\n\
>
> By default, include function names and source lines.

Fixed.

> And I have a question: how to turn off all the optional print-outs?
> Is there a /no-f modifier or something?

No, there isn't. Everything is optional, except for the block number. If you wanted to turn off everything, you would get a list of integers, which would be fairly useless. You can get the total number of blocks using /t.

> > +Without arguments, the full list of blocks is listed.\n\
> > +With a range (<start>[-<end>]) argument, lists all blocks in that range.\n"),
>
> Again, use active tense, and "list" instead of "lists".

Fixed.

Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052