From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7424 invoked by alias); 30 Nov 2012 07:35:54 -0000 Received: (qmail 7087 invoked by uid 22791); 30 Nov 2012 07:35:53 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 07:35:49 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TeL8W-00056N-PF from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 29 Nov 2012 23:35:48 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 29 Nov 2012 23:35:48 -0800 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 29 Nov 2012 23:35:47 -0800 From: Yao Qi To: Subject: [committed] Remove a redundant condition check in tic6x-linux-tdep.c Date: Fri, 30 Nov 2012 07:35:00 -0000 Message-ID: <1354260922-13995-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00910.txt.bz2 Hi, When gdb is configured as target=tic6x-uclinux, and compiled with clang, I get this warning: gdb/tic6x-linux-tdep.c:66:19: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare] It is redundant to check 'REGNUM >= 0' as it is unsigned. The following patch is to fix it. Committed. gdb: 2012-11-30 Yao Qi * tic6x-linux-tdep.c (tic6x_register_sigcontext_offset): Don't check REGNUM >= 0. --- gdb/tic6x-linux-tdep.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/tic6x-linux-tdep.c b/gdb/tic6x-linux-tdep.c index 3b96201..f4450c9 100644 --- a/gdb/tic6x-linux-tdep.c +++ b/gdb/tic6x-linux-tdep.c @@ -63,7 +63,7 @@ tic6x_register_sigcontext_offset (unsigned int regnum, struct gdbarch *gdbarch) else if (regnum == TIC6X_B5_REGNUM || regnum == TIC6X_B5_REGNUM + 2 || regnum == TIC6X_B5_REGNUM + 4) return 4 * (regnum - TIC6X_B5_REGNUM + 19); /* B5, B7, B9 */ - else if (regnum >= 0 && regnum < TIC6X_A4_REGNUM) + else if (regnum < TIC6X_A4_REGNUM) return 4 * (regnum - 0 + 8); /* A0 - A3 */ else if (regnum >= TIC6X_B0_REGNUM && regnum < TIC6X_B4_REGNUM) return 4 * (regnum - TIC6X_B0_REGNUM + 15); /* B0 - B3 */ -- 1.7.7.6