Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Wielaard <mjw@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: dje.gcc@gmail.com, geoffk@geoffk.org, jakub@redhat.com,
	       gcc-patches@gcc.gnu.org, binutils@sourceware.org,
	       gdb-patches@sourceware.org
Subject: Re: [RFC] Wrong register numbers in .dwarf_frame on Linux/PowerPC
Date: Wed, 28 Nov 2012 11:27:00 -0000	[thread overview]
Message-ID: <1354101985.3668.4.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: <201211271849.qARInCSZ031343@d06av02.portsmouth.uk.ibm.com>

On Tue, 2012-11-27 at 19:49 +0100, Ulrich Weigand wrote:
> Mark Wielaard wrote:
> 
> > Which other unwinders are out there, that might rely on the current
> > numbering?
> 
> Well, runtime unwinders using .eh_frame should be fine, since this
> uses (and has always used) consistently the GCC numbering.  I don't
> know if there are other unwinders using .dwarf_frame ...

The reason systemtap hits this is that it can do unwinding of both user
and kernel space. The linux kernel doesn't include eh_frames, so we have
to fall back to .debug_frame.

> The change will most likely be to consistently use GCC numbering in
> .dwarf_frame as well, which changes only the encoding of the condition
> code register.  Since you're not using that at all in systemtap, you
> shouldn't be affected.

Yeah, we only use the unwinder currently to produce backtraces, which
are unlikely to rely on the condition code register.

> As far as Linux goes, yes, ppc was the only architecture with a
> different encoding between .eh_frame and .dwarf_frame.

In that case your option 3 seems ideal.

Thanks,

Mark


      reply	other threads:[~2012-11-28 11:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-26 19:10 Ulrich Weigand
2012-11-26 20:04 ` David Edelsohn
2012-11-27 19:12   ` Ulrich Weigand
2012-11-26 20:14 ` Mark Kettenis
2012-11-27 18:43   ` Ulrich Weigand
2012-11-27 19:13     ` Mark Kettenis
2012-11-27  9:26 ` Mark Wielaard
2012-11-27 18:49   ` Ulrich Weigand
2012-11-28 11:27     ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354101985.3668.4.camel@bordewijk.wildebeest.org \
    --to=mjw@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=geoffk@geoffk.org \
    --cc=jakub@redhat.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox