RE: [patch v4 03/13] cli, btrace: add btrace cli

Metzger, Markus T
2012-11-30T15:23:52Z

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Jan Kratochvil
> Sent: Friday, November 30, 2012 4:16 PM
> To: Metzger, Markus T
> Cc: Tom Tromey; gdb-patches@sourceware.org; markus.t.metzger@gmail.com; palves@redhat.com; kettenis@gnu.org
> Subject: Re: [patch v4 03/13] cli, btrace: add btrace cli
>
> On Fri, 30 Nov 2012 16:09:02 +0100, Metzger, Markus T wrote:
> > The easiest thing for me to do would be to only print "()" if lang !=
> > language_cplus. Since the demangler prints the parameters right after the
> > function name, though, I would also remove the space before "()" for other
> > languages.
>
> http://www.gnu.org/prep/standards/standards.html#GNU-Manuals
> Please do not write '()' after a function name just to indicate it is
> a function. foo () is not a function, it is a function call with no
> arguments.

In that case, I would just drop the "()" altogether and print whatever SYMBOL_PRINT_NAME returns.

Thanks,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052