Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Skip gcore-buffer-overflow.exp on windows
Date: Thu, 15 Nov 2012 15:02:00 -0000	[thread overview]
Message-ID: <1352991707-29104-1-git-send-email-yao@codesourcery.com> (raw)

Hi,
When running gcore-buffer-overflow.exp on ia32/windows host,
we saw the following error,

  cp: accessing `XXX/gdb.base/gcore-buffer-overflow-01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789': File name too long

Looks we don't have other supported hosts that have file name length
limitation, so this patch simply skips it on windows.  Is it OK?

gdb/testsuite:

2012-11-15  Daniel Jacobowitz  <dan@codesourcery.com>
	    Yao Qi  <yao@codesourcery.com>

	* gdb.base/gcore-buffer-overflow.exp: Skip on Windows.
---
 gdb/testsuite/gdb.base/gcore-buffer-overflow.exp |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
index 13c3e75..45139bd 100644
--- a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
+++ b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
@@ -15,6 +15,11 @@
 
 # Test GDB's internal buffers safety for the GCORE command.
 
+# Skip this test on Windows; the long filename is not allowed.
+if { [ishost "i?86-*-mingw*"] } {
+    untested gcore-buffer-overflow.exp
+    return -1
+}
 
 set testfile "gcore-buffer-overflow"
 set srcfile  ${testfile}.c
-- 
1.7.7.6


             reply	other threads:[~2012-11-15 15:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 15:02 Yao Qi [this message]
2012-11-15 15:21 ` Joel Brobecker
2012-11-15 16:04 ` Pedro Alves
2012-11-15 17:09 ` Eli Zaretskii
2012-11-16  1:11   ` Yao Qi
2012-11-16 15:57     ` Eli Zaretskii
2012-11-19  2:41       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352991707-29104-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox