From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18131 invoked by alias); 8 Oct 2012 11:43:34 -0000 Received: (qmail 18063 invoked by uid 22791); 8 Oct 2012 11:43:33 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 11:43:24 +0000 Received: by mail-pb0-f41.google.com with SMTP id rq2so4457850pbb.0 for ; Mon, 08 Oct 2012 04:43:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=k34yNX4mXHHYCD3dObJ2C/HrdF4sLWX4iQiSDPjaYq4=; b=l+HTVdFEypmmjKFDlwidqbNUWsuPRFFXEOq8mFBxvJZD9Xh91D3EBEi64Fazn0djJY IoQwtSAKm1CZbqwvQlt8yI1TEiXCXVawUfnRF5SlInkfhLZdRe/cU5wVm3qODvcSr7vk EVesKmWg+YJXR2tYidDmMsJk0MzH4HAhijd1t2VaSdDe4eXH1h5rnanO+/YzoX3DNeBY Um245Gg7OmG0v+BpGASsmejyT9BS3tXMQOcRoY4H4oI4+m4Bj4Thcx7vwwF0qA1h63kn gyU5f7PCzfrXADkatat+Gmd9aYvmKUTGI5vy6ilnOsuUC7kS+PNB9nqdrzjG1uUX6+vh cC0w== Received: by 10.68.239.5 with SMTP id vo5mr52290642pbc.102.1349696603706; Mon, 08 Oct 2012 04:43:23 -0700 (PDT) Received: from divine-comedy.divine-comedy (ec2-122-248-217-158.ap-southeast-1.compute.amazonaws.com. [122.248.217.158]) by mx.google.com with ESMTPS id st6sm10607988pbc.58.2012.10.08.04.43.20 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Oct 2012 04:43:22 -0700 (PDT) From: Sanjoy Das To: gdb-patches@sourceware.org Cc: Sanjoy Das Subject: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects. Date: Mon, 08 Oct 2012 11:43:00 -0000 Message-Id: <1349696849-9056-3-git-send-email-sanjoy@playingwithpointers.com> In-Reply-To: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> References: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> X-Gm-Message-State: ALoCoQkoVuM1bJNMcFHt9OPcZDMxH/ryUSCLkYLhh8rs0AZR4p3Msuf7ku6WzWx/EB5MdTMirQKa X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00125.txt.bz2 --- gdb/ChangeLog | 5 +++++ gdb/doc/ChangeLog | 4 ++++ gdb/doc/gdb.texinfo | 22 +++++++++++++--------- gdb/jit.c | 6 +++++- 4 files changed, 27 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e57e5c1..01ee95d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2012-10-08 Sanjoy Das + * jit.c (jit_reader_load_command): Interpret the jit reader name + as an absolute path if it begins with a forward slash. + +2012-09-18 Sanjoy Das + PR gdb/14550 * jit.c (finalize_symtab): Ensure that only the global block has a diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 05ac406..8cdca61 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2012-10-05 Sanjoy Das + * gdb.texinfo (Using JIT Debug Info Readers): Change documentation + to reflect that jit-reader-load now supports absolute file-names. + 2012-09-26 Siddhesh Poyarekar * observer.texi (memory_changed): Expand parameter LEN to ssize_t. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 5fcbada..c28b803 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -33436,15 +33436,19 @@ Readers can be loaded and unloaded using the @code{jit-reader-load} and @code{jit-reader-unload} commands. @table @code -@item jit-reader-load @var{reader-name} -Load the JIT reader named @var{reader-name}. On a UNIX system, this -will usually load @file{@var{libdir}/gdb/@var{reader-name}}, where -@var{libdir} is the system library directory, usually -@file{/usr/local/lib}. Only one reader can be active at a time; -trying to load a second reader when one is already loaded will result -in @value{GDBN} reporting an error. A new JIT reader can be loaded by -first unloading the current one using @code{jit-reader-load} and then -invoking @code{jit-reader-load}. +@item jit-reader-load @var{reader} +Load the JIT reader named @var{reader}. @var{reader} is a shared +object specified as either an absolute or a relative file name. In +the latter case, gdb will try to load the reader from a pre-configured +directory, usually @file{@var{libdir}/gdb/} on a UNIX system (here +@var{libdir} is the system library directory, often +@file{/usr/local/lib}). + +Only one reader can be active at a time; trying to load a second +reader when one is already loaded will result in @value{GDBN} +reporting an error. A new JIT reader can be loaded by first unloading +the current one using @code{jit-reader-unload} and then invoking +@code{jit-reader-load}. @item jit-reader-unload Unload the currently loaded JIT reader. diff --git a/gdb/jit.c b/gdb/jit.c index eff2ed6..fb6658f 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -25,6 +25,7 @@ #include "breakpoint.h" #include "command.h" #include "dictionary.h" +#include "filenames.h" #include "frame-unwind.h" #include "gdbcmd.h" #include "gdbcore.h" @@ -208,7 +209,10 @@ jit_reader_load_command (char *args, int from_tty) if (loaded_jit_reader != NULL) error (_("JIT reader already loaded. Run jit-reader-unload first.")); - so_name = xstrprintf ("%s/%s", jit_reader_dir, args); + if (IS_ABSOLUTE_PATH (args)) + so_name = xstrdup (args); + else + so_name = xstrprintf ("%s/%s", jit_reader_dir, args); prev_cleanup = make_cleanup (xfree, so_name); loaded_jit_reader = jit_reader_load (so_name); -- 1.7.10.4