From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17822 invoked by alias); 8 Oct 2012 11:43:27 -0000 Received: (qmail 17709 invoked by uid 22791); 8 Oct 2012 11:43:24 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 11:43:21 +0000 Received: by mail-pb0-f41.google.com with SMTP id rq2so4457812pbb.0 for ; Mon, 08 Oct 2012 04:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=iI5GArhfpH4A/Nc77Qs2d9cD/sm2Dl0U4iFodYsyQmk=; b=KiJV6QMVA/MxfESyuivVGiYv5yrrT+eDA5OCtZj5brgpwgCRuj9+Pvg6LCcppkX5cI NoOuXoOgwFSR5CTLRg91s+w5KF32jxhq5ei7E0GCPH6iNh+hWxfN6kH3Fv1dZgW4bJMA Ll5zKWFl+Mex7Vw8dPwWz7xaMC2FRGaVhJEjP8iwpckYhFqGQ3YgVseVdPG2ptDwtbrW B3EgMi7Vobk/yN3qrIKXg7zcU2vncDgd5QigfIuma8orJL0EhWl6ZTJM5Jihx2zybXGL 3LeHunEqmP8mvJkH/FeaKhYCVkjgQ5BRDU0f3Ek8Uf9Dq9MKOgNZfP9bO6cjZ9lmAoDf U4nQ== Received: by 10.68.212.71 with SMTP id ni7mr51887525pbc.81.1349696600611; Mon, 08 Oct 2012 04:43:20 -0700 (PDT) Received: from divine-comedy.divine-comedy (ec2-122-248-217-158.ap-southeast-1.compute.amazonaws.com. [122.248.217.158]) by mx.google.com with ESMTPS id st6sm10607988pbc.58.2012.10.08.04.43.18 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Oct 2012 04:43:19 -0700 (PDT) From: Sanjoy Das To: gdb-patches@sourceware.org Cc: Sanjoy Das Subject: [PATCH 1/3] Fix segfault when unwinding JIT frames using a custom reader. Date: Mon, 08 Oct 2012 11:43:00 -0000 Message-Id: <1349696849-9056-2-git-send-email-sanjoy@playingwithpointers.com> In-Reply-To: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> References: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> X-Gm-Message-State: ALoCoQk6jZi5UIuR6lbLgGgHKuGQRjZnU2YCRrY/bVIAYFqtHwiJiT8nTxKi2lV1bLi7cArzd5V6 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00126.txt.bz2 Issue http://sourceware.org/bugzilla/show_bug.cgi?id=14550 --- gdb/ChangeLog | 7 +++++++ gdb/jit.c | 14 ++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8fe5e27..e57e5c1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2012-10-08 Sanjoy Das + + PR gdb/14550 + + * jit.c (finalize_symtab): Ensure that only the global block has a + NULL superblock. + 2012-10-06 Jan Kratochvil Fix crash during stepping on ppc32. diff --git a/gdb/jit.c b/gdb/jit.c index 9e8f295..eff2ed6 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -724,8 +724,18 @@ finalize_symtab (struct gdb_symtab *stab, struct objfile *objfile) gdb_block_iter = gdb_block_iter->next) { if (gdb_block_iter->parent != NULL) - BLOCK_SUPERBLOCK (gdb_block_iter->real_block) = - gdb_block_iter->parent->real_block; + { + /* If the plugin specifically mentioned a parent block, we + use that. */ + BLOCK_SUPERBLOCK (gdb_block_iter->real_block) = + gdb_block_iter->parent->real_block; + } + else + { + /* And if not, we set a default parent block. */ + BLOCK_SUPERBLOCK (gdb_block_iter->real_block) = + BLOCKVECTOR_BLOCK (symtab->blockvector, STATIC_BLOCK); + } } /* Free memory. */ -- 1.7.10.4