From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22289 invoked by alias); 14 Aug 2012 13:00:11 -0000 Received: (qmail 22279 invoked by uid 22791); 14 Aug 2012 13:00:09 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Aug 2012 12:59:55 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 14 Aug 2012 05:59:54 -0700 X-ExtLoop1: 1 Received: from swsutil001.isw.intel.com ([10.237.237.11]) by fmsmga002.fm.intel.com with ESMTP; 14 Aug 2012 05:59:52 -0700 Received: from ulslx001.iul.intel.com (ulslx001.iul.intel.com [172.28.207.63]) by swsutil001.isw.intel.com (8.13.6/8.13.6/MailSET/Hub) with ESMTP id q7ECxpG8029039; Tue, 14 Aug 2012 13:59:52 +0100 Received: from ulslx001.iul.intel.com (localhost [127.0.0.1]) by ulslx001.iul.intel.com with ESMTP id q7ECxpCR009890; Tue, 14 Aug 2012 14:59:51 +0200 Received: (from mmetzger@localhost) by ulslx001.iul.intel.com with id q7ECxpPp009886; Tue, 14 Aug 2012 14:59:51 +0200 From: markus.t.metzger@intel.com To: gdb-patches@sourceware.org Cc: markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com, tromey@redhat.com, kettenis@gnu.org, Markus Metzger Subject: [patch v3 02/16] disas: add precise instructions flag Date: Tue, 14 Aug 2012 13:00:00 -0000 Message-Id: <1344949171-9545-3-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00386.txt.bz2 From: Markus Metzger When disassembling an address range with interleaved sources, the addresses that are being disassembled may not exactly match the specified range. Addresses may be: - added after the specified range - omitted at the beginning of the specified range Add a new disassembly flag that fixes the above two cases. 2012-08-14 Markus Metzger * disasm.h: Add new flag DISASSEMBLY_PRECISE_INSN. * disasm.c (do_mixed_source_and_assembly): Adjust mle boundaries. --- gdb/disasm.c | 26 ++++++++++++++++++++++---- gdb/disasm.h | 7 ++++--- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/gdb/disasm.c b/gdb/disasm.c index e3d3349..c5c35ea 100644 --- a/gdb/disasm.c +++ b/gdb/disasm.c @@ -217,13 +217,22 @@ do_mixed_source_and_assembly (struct gdbarch *gdbarch, struct ui_out *uiout, /* First, skip all the preceding functions. */ - for (i = 0; i < nlines - 1 && le[i].pc < low; i++); + /* If we want precise instructions, we only skip the line entries for which + the pc range between this and the next entry precedes the requested + instruction range. */ + if (flags & DISASSEMBLY_PRECISE_INSN) + for (i = 0; i < nlines - 2 && le[i + 1].pc <= low; i++); + else + for (i = 0; i < nlines - 1 && le[i].pc < low; i++); /* Now, copy all entries before the end of this function. */ for (; i < nlines - 1 && le[i].pc < high; i++) { - if (le[i].line == le[i + 1].line && le[i].pc == le[i + 1].pc) + CORE_ADDR start = le[i].pc; + CORE_ADDR end = le[i + 1].pc; + + if (le[i].line == le[i + 1].line && start == end) continue; /* Ignore duplicates. */ /* Skip any end-of-function markers. */ @@ -233,8 +242,17 @@ do_mixed_source_and_assembly (struct gdbarch *gdbarch, struct ui_out *uiout, mle[newlines].line = le[i].line; if (le[i].line > le[i + 1].line) out_of_order = 1; - mle[newlines].start_pc = le[i].pc; - mle[newlines].end_pc = le[i + 1].pc; + + /* If we want precise instructions, adjust the line ranges to only contain + instructions in the requested range. */ + if (flags & DISASSEMBLY_PRECISE_INSN) + { + end = min (end, high); + start = max (start, low); + } + + mle[newlines].start_pc = start; + mle[newlines].end_pc = end; newlines++; } diff --git a/gdb/disasm.h b/gdb/disasm.h index 646ee8e..5b459f4 100644 --- a/gdb/disasm.h +++ b/gdb/disasm.h @@ -19,9 +19,10 @@ #ifndef DISASM_H #define DISASM_H -#define DISASSEMBLY_SOURCE (0x1 << 0) -#define DISASSEMBLY_RAW_INSN (0x1 << 1) -#define DISASSEMBLY_OMIT_FNAME (0x1 << 2) +#define DISASSEMBLY_SOURCE (0x1 << 0) +#define DISASSEMBLY_RAW_INSN (0x1 << 1) +#define DISASSEMBLY_OMIT_FNAME (0x1 << 2) +#define DISASSEMBLY_PRECISE_INSN (0x1 << 3) struct ui_out; struct ui_file; -- 1.7.1