Re: [PATCH 1/3] var_zuinteger_unlimited and 'set listsize'.

Yao Qi
2012-08-02T12:53:27Z

On Thursday, August 02, 2012 01:33:58 AM Doug Evans wrote:
> Nit: The changelog entry for source.c should mention "listsize". And
> the entry for do_setshow_command should also mention that it fixes the
> setting of var_integer and var_zinteger to allow negative values.
>

Thanks, I'll fix changelog entries.

> Things are quite a mess, aren't they.
> Adding yet another var_foo doesn't appeal to me, but we can't break
> anything and being able to set both "0" and "unlimited" (expressed
> however) would be nice.
>

Agreed.

> Is there any real use-case that wants to be able to set negative
> values and have "0" mean unlimited? It's never (until this patch)
> been the case that one can set negative values to var_integer. Can we
> remove (or at least deprecate) var_integer? [we'd switch all existing
> uses to var_uinteger, the only remaining use would be the Python API]

Yes, I was inclined to switch *all* var_integer to var_uinteger, and it is
still ongoing. It is independent of this patch series, but my 'command option
changes notification' patches reply on this series, so I hope this series can
go in at first.

>
> btw, you also might want to update python/py-param.c.
> Though py-param.c also doesn't handle var_zuinteger, and I don't mind
> not extending the Python API until we know we want to.

I'll look at python stuff in next step.

--
Yao (齐尧)