From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17981 invoked by alias); 25 Jul 2012 20:04:09 -0000 Received: (qmail 17970 invoked by uid 22791); 25 Jul 2012 20:04:08 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailrelay005.isp.belgacom.be (HELO mailrelay005.isp.belgacom.be) (195.238.6.171) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 20:03:54 +0000 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtIBAPhPEFBR9qAt/2dsb2JhbAANOIVxsT+FRAEBAQQjVhALGAICJgICVwYur1duky2BIJAPgRIDnnSJQw Received: from 45.160-246-81.adsl-dyn.isp.belgacom.be (HELO [192.168.1.2]) ([81.246.160.45]) by relay.skynet.be with ESMTP; 25 Jul 2012 22:03:50 +0200 Subject: Re: [patch] [i386] Put hlt at the ON_STACK breakpoint [Re: GDB 7.4.91 available for testing] From: Philippe Waroquiers To: Joel Brobecker Cc: Jan Kratochvil , gdb-patches@sourceware.org, Pedro Alves In-Reply-To: <20120725144858.GB24718@adacore.com> References: <20120720071158.GA7053@host2.jankratochvil.net> <1342817409.2149.41.camel@soleil> <20120722173053.GA22036@host2.jankratochvil.net> <1342983655.2301.55.camel@soleil> <20120723072125.GA12958@host2.jankratochvil.net> <20120723155951.GA24718@adacore.com> <20120723163513.GA1222@host2.jankratochvil.net> <1343074047.2209.23.camel@soleil> <20120723201611.GA19567@host2.jankratochvil.net> <1343075809.2209.53.camel@soleil> <20120725144858.GB24718@adacore.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 25 Jul 2012 20:04:00 -0000 Message-ID: <1343246641.2240.8.camel@soleil> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00580.txt.bz2 On Wed, 2012-07-25 at 07:48 -0700, Joel Brobecker wrote: > > If there will be a clean solution in GDB (7.5 or 7.6), then I will not > > commit the kludge in Valgrind. > > I also think that it would be friendlier to all valgrind users if > we tried to fix the problem on the GDB side before 7.5 gets out. > It seems like it would be easy enough, or is something else other > than Jan's patch necessary? IIUC, Jan's patch was to have GDB storing a hlt after the place where GDBSERVER will put 0xCC. What Valgrind needs is to have GDB storing the 0xCC (the hlt will then have no positive nor negative impact on Valgrind). Philippe