From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31477 invoked by alias); 25 Jun 2012 17:55:00 -0000 Received: (qmail 31460 invoked by uid 22791); 25 Jun 2012 17:54:58 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-gg0-f169.google.com (HELO mail-gg0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jun 2012 17:54:40 +0000 Received: by ggm4 with SMTP id 4so3750261ggm.0 for ; Mon, 25 Jun 2012 10:54:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :organization:content-type:x-mailer:content-transfer-encoding :mime-version:x-gm-message-state; bh=V41l6N6ggYAGuEs3kAkfYtzgx6/+03qpd+iLmaUcbiQ=; b=omC6t4PkpwAFy30RIA8P8N26rSMVpEqICDuxGYlM9lquhyA5pY2E1CxbJAJFfvXe5P wbcD9wDPMJksoQElCyM1KkiKDxIkEt9/AuMWA2Y+OV+JTc/YNO3nNq0gSYpf9u/N7TNK qQKf0wAF3keI5OLuqaXsuYUx5wSs8HCPfp8x0CciHPoqpraptkXQznHS8+HH0BuThKMg qHedpYLmWY9Rbp+dtldA2JnabctsceJB597nGAjLqSRof+3hV09a8F1LTkVRKYWMc08T 4xMh6P14uc44eU4LqlAv1368qdYhvvNkqETGwrni3QC4LaZyubKIj8Gzl3+PdnFNfFzx x4ew== Received: by 10.236.165.74 with SMTP id d50mr14100922yhl.118.1340646879621; Mon, 25 Jun 2012 10:54:39 -0700 (PDT) Received: from [192.168.1.50] ([177.42.106.33]) by mx.google.com with ESMTPS id w61sm135029564yhi.5.2012.06.25.10.54.37 (version=SSLv3 cipher=OTHER); Mon, 25 Jun 2012 10:54:38 -0700 (PDT) Message-ID: <1340646873.31308.30.camel@hactar> Subject: Re: [patch] Support bionic's jmp_buf. From: Thiago Jung Bauermann To: Yao Qi Cc: gdb-patches@sourceware.org, Pedro Alves Date: Mon, 25 Jun 2012 17:55:00 -0000 In-Reply-To: <2077698.dhnsbKdz32@qiyao.dyndns.org> References: <1337560528.4363.13.camel@hactar> <1337623164.22073.9.camel@hactar> <1340574375.31308.7.camel@hactar> <2077698.dhnsbKdz32@qiyao.dyndns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Gm-Message-State: ALoCoQkD77Dc+zZINyTSZOCg9bChXzjNb0DNQocXgSFwVhnS37So0fVycaoTCwhXgzHY73DCCyuo X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00777.txt.bz2 Hello, On Mon, 2012-06-25 at 21:32 +0800, Yao Qi wrote: > On Sunday, June 24, 2012 06:46:15 PM Thiago Jung Bauermann wrote: > > +/* Determines whether the inferior is an Android application. */ > > + > > +static int > > +is_target_linux_android (void) > > Looks this function is not arm-specific, so we can move it to linux-tdep.c. Thanks for your review. Android is officially supported on ARM and x86. I don't know how GDB fares on Android on x86, and at least for now it will only be used on ARM (I don't have plans to work on Android on x86). With that said, I'm happy to move to linux-tdep.c if that makes more sense. I'll do the change before I commit or on the next iteration of the patch if there is one. -- []'s Thiago Jung Bauermann Linaro Toolchain Working Group