Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] [testsuite] Fix in board_file native-gdbserver.exp
Date: Thu, 21 Jun 2012 07:55:00 -0000	[thread overview]
Message-ID: <1340265300-4881-1-git-send-email-yao@codesourcery.com> (raw)

Hi,
When I use following statement in test case with native-gdbserver.exp board_file,
I got one error,

  remote_exec target "sh -c { \[ -f /bin/ls \] }"

  WARNING: program timed out.
  FAIL: gdb.base/foo.exp: exists /bin/ls

Examine the verbose log shows that dejagnu thinks native-gdbserver is a
remote target, and will try to use remote method, rsh for example, to
access files,

 Executing on target: sh -c { [ -f /bin/ls ] }    (timeout = 300)
 calling is_remote target
 board_info build name
 getting qiyao name
 board_info host name
 getting qiyao name
 calling is_remote native-gdbserver
 board_info build name
 getting qiyao name
 board_info host name
 getting qiyao name
 board_info native-gdbserver exists isremote
 board_info native-gdbserver isremote
 getting native-gdbserver isremote
 board is native-gdbserver, isremote is 1

This patch add new proc ${board}_exec to wrap remote_exec with setting
isremote to 0 temporarily.  Running test suite with native-gdbserver,
no change on result.

Note that such problem doesn't exist on board_file
native-extended-gdbserver.exp because isremote always is set to 0 in it.

gdb/testsuite:

2012-06-21  Yao Qi  <yao@codesourcery.com>

	* boards/native-gdbserver.exp: New proc ${board}_exec.
---
 gdb/testsuite/boards/native-gdbserver.exp |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/gdb/testsuite/boards/native-gdbserver.exp b/gdb/testsuite/boards/native-gdbserver.exp
index 5fa02a4..89702df 100644
--- a/gdb/testsuite/boards/native-gdbserver.exp
+++ b/gdb/testsuite/boards/native-gdbserver.exp
@@ -64,6 +64,18 @@ proc ${board}_spawn { board cmd } {
     return $result
 }
 
+proc ${board}_exec { hostname program args } {
+    global board_info
+
+    set baseboard [lindex [split $hostname "/"] 0]
+
+    set board_info($baseboard,isremote) 0
+    set result [remote_exec $hostname $program $args]
+    set board_info($baseboard,isremote) 1
+
+    return $result
+}
+
 proc ${board}_download { board host dest } {
     return $host
 }
-- 
1.7.7.6


             reply	other threads:[~2012-06-21  7:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21  7:55 Yao Qi [this message]
2012-06-21 14:02 ` Pedro Alves
2012-06-22  7:49   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340265300-4881-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox