From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6829 invoked by alias); 30 May 2012 18:36:01 -0000 Received: (qmail 6443 invoked by uid 22791); 30 May 2012 18:35:59 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 May 2012 18:35:41 +0000 Received: by vbbey12 with SMTP id ey12so103670vbb.0 for ; Wed, 30 May 2012 11:35:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :organization:content-type:x-mailer:content-transfer-encoding :mime-version:x-gm-message-state; bh=C6bvV/+3nplnMUugnOs2xZnM4UUMzWJSvghujGwotCE=; b=KiyACw2Lrtxm5XBqgxzHpChrr9EvebV+zkf1aNCJOGBTwZB5jsN9WWWOyy0cUXKgP9 mxHNZfSgZPCpje03vBCVVUaGQaenfxczFlfsC+o1tJDGwRQY2G8DYGl1FtyTMR0vTN9o rIPr35rZaRBlL2ZbDX3zYlPpiOHIjGBP+r25S0gseacFEfjYcRcHBf6fMwcA3XUz9kTx F89mfkaCGBVca4LNWYs82DquzhX/0hZGQjn0fJIJAl93786mHBtyEBIWZ7OGDVM8R0ki wV8zNsAyFKajPnu6DnKJQd5QzW9syVLdgW8fjGThIipBTVPeMwljDC8yafFIl7ldhY2L a0Qg== Received: by 10.52.93.202 with SMTP id cw10mr15410963vdb.1.1338402940376; Wed, 30 May 2012 11:35:40 -0700 (PDT) Received: from [192.168.1.50] ([177.16.42.188]) by mx.google.com with ESMTPS id j2sm711297vde.16.2012.05.30.11.35.37 (version=SSLv3 cipher=OTHER); Wed, 30 May 2012 11:35:38 -0700 (PDT) Message-ID: <1338402935.22894.12.camel@hactar> Subject: Re: [RFA] Define DT_MIPS_RLD_MAP if not already defined. From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches ml Date: Wed, 30 May 2012 18:36:00 -0000 In-Reply-To: <4FC660E6.9010904@redhat.com> References: <1338352816.3618.5.camel@hactar> <4FC660E6.9010904@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Gm-Message-State: ALoCoQlCRziDd2S2fvjQc8EubP1u9AVpqYWqHhAwTWPRECSCJnk+oQoi+RxjrHJ1Ao3zWnnN+SA0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg01047.txt.bz2 On Wed, 2012-05-30 at 19:03 +0100, Pedro Alves wrote: > On 05/30/2012 05:40 AM, Thiago Jung Bauermann wrote: > > Hello, > > > > Android doesn't support MIPS, so understandably there's no > > DT_MIPS_RLD_MAP in its header files. This patch allows gdbserver to be > > compiled for Android. > > Then why not '#ifdef DT_MIPS_RLD_MAP' out the bits that use DT_MIPS_RLD_MAP ? > It's just dead code on non-MIPS ports. I thought #ifdef'ing platform-specific code was discouraged in GDB. I can certainly do that though. -- []'s Thiago Jung Bauermann Linaro Toolchain Working Group