From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12316 invoked by alias); 3 May 2012 19:03:45 -0000 Received: (qmail 12159 invoked by uid 22791); 3 May 2012 19:03:43 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 May 2012 19:03:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AC59B1C6C74; Thu, 3 May 2012 15:03:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Vrk14ZACnBiF; Thu, 3 May 2012 15:03:27 -0400 (EDT) Received: from kwai.gnat.com (kwai.gnat.com [205.232.38.4]) by rock.gnat.com (Postfix) with ESMTP id 708A01C6C6B; Thu, 3 May 2012 15:03:27 -0400 (EDT) Received: by kwai.gnat.com (Postfix, from userid 4233) id 719F33FEE8; Thu, 3 May 2012 15:03:27 -0400 (EDT) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: macro@codesourcery.com, Joel Brobecker Subject: [commit 2/2] Remove AT_SYMBOL Date: Thu, 03 May 2012 19:03:00 -0000 Message-Id: <1336071802-13599-3-git-send-email-brobecker@adacore.com> In-Reply-To: <1336071802-13599-1-git-send-email-brobecker@adacore.com> References: <1336071802-13599-1-git-send-email-brobecker@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00101.txt.bz2 Now that this method is no longer used by any architecture, we can remove its support. gdb/ChangeLog: * infcall.c (call_function_by_hand): Remove AT_SYMBOL handling. * inferior.h (AT_SYMBOL): Delete. Will commit as soon as the mips-tdep patch gets checked in. --- gdb/infcall.c | 27 --------------------------- gdb/inferior.h | 1 - 2 files changed, 0 insertions(+), 28 deletions(-) diff --git a/gdb/infcall.c b/gdb/infcall.c index 6c250e3..e0195c9 100644 --- a/gdb/infcall.c +++ b/gdb/infcall.c @@ -640,33 +640,6 @@ call_function_by_hand (struct value *function, int nargs, struct value **args) bp_addr = dummy_addr; break; } - case AT_SYMBOL: - /* Some executables define a symbol __CALL_DUMMY_ADDRESS whose - address is the location where the breakpoint should be - placed. Once all targets are using the overhauled frame code - this can be deleted - ON_STACK is a better option. */ - { - struct minimal_symbol *sym; - CORE_ADDR dummy_addr; - - sym = lookup_minimal_symbol ("__CALL_DUMMY_ADDRESS", NULL, NULL); - real_pc = funaddr; - if (sym) - { - dummy_addr = SYMBOL_VALUE_ADDRESS (sym); - /* Make certain that the address points at real code, and not - a function descriptor. */ - dummy_addr = gdbarch_convert_from_func_ptr_addr (gdbarch, - dummy_addr, - ¤t_target); - } - else - dummy_addr = entry_point_address (); - /* A call dummy always consists of just a single breakpoint, - so it's address is the same as the address of the dummy. */ - bp_addr = dummy_addr; - break; - } default: internal_error (__FILE__, __LINE__, _("bad switch")); } diff --git a/gdb/inferior.h b/gdb/inferior.h index 63245a2..8c90f96 100644 --- a/gdb/inferior.h +++ b/gdb/inferior.h @@ -357,7 +357,6 @@ struct displaced_step_closure *get_displaced_step_closure_by_addr (CORE_ADDR add /* Possible values for gdbarch_call_dummy_location. */ #define ON_STACK 1 #define AT_ENTRY_POINT 4 -#define AT_SYMBOL 5 /* If STARTUP_WITH_SHELL is set, GDB's "run" will attempts to start up the debugee under a shell. -- 1.7.0.4