From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15323 invoked by alias); 16 Apr 2012 21:14:23 -0000 Received: (qmail 15315 invoked by uid 22791); 16 Apr 2012 21:14:22 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 21:14:10 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id EB1F829004A; Mon, 16 Apr 2012 23:14:14 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7b7Yavn9JduS; Mon, 16 Apr 2012 23:14:14 +0200 (CEST) Received: from chinon.act-europe.fr (chinon.act-europe.fr [10.10.0.182]) by mel.act-europe.fr (Postfix) with ESMTP id D9535290025; Mon, 16 Apr 2012 23:14:14 +0200 (CEST) Received: by chinon.act-europe.fr (Postfix, from userid 507) id 96543D98A1; Mon, 16 Apr 2012 23:14:08 +0200 (CEST) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Joel Brobecker Subject: [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Date: Mon, 16 Apr 2012 21:14:00 -0000 Message-Id: <1334610821-10974-2-git-send-email-brobecker@adacore.com> In-Reply-To: <1334610821-10974-1-git-send-email-brobecker@adacore.com> References: <1334610821-10974-1-git-send-email-brobecker@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00440.txt.bz2 Some local variables are being set, but never used. This patch deletes them. gdb/ChangeLog: * xcoffread.c (read_xcoff_symtab): Delete variables last_csect_val and last_csect_sec and associated code. This patch is actually independent of the series, but it was triggered by the investigation of the internal-error when creating a breakpoint. I will commit as soon as testing is complete. --- gdb/xcoffread.c | 15 +++------------ 1 files changed, 3 insertions(+), 12 deletions(-) diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 86ae8fb..fcabddb 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -986,9 +986,7 @@ read_xcoff_symtab (struct partial_symtab *pst) char *filestring = " _start_ "; /* Name of the current file. */ - const char *last_csect_name; /* Last seen csect's name and value. */ - CORE_ADDR last_csect_val; - int last_csect_sec; + const char *last_csect_name; /* Last seen csect's name. */ this_symtab_psymtab = pst; @@ -998,7 +996,6 @@ read_xcoff_symtab (struct partial_symtab *pst) last_source_file = NULL; last_csect_name = 0; - last_csect_val = 0; start_stabs (); start_symtab (filestring, (char *) NULL, file_start_addr); @@ -1171,14 +1168,8 @@ read_xcoff_symtab (struct partial_symtab *pst) SECT_OFF_TEXT (objfile)); file_end_addr = file_start_addr + CSECT_LEN (&main_aux); - if (cs->c_name && (cs->c_name[0] == '.' - || cs->c_name[0] == '@')) - { - last_csect_name = cs->c_name; - last_csect_val = cs->c_value; - last_csect_sec = secnum_to_section (cs->c_secnum, - objfile); - } + if (cs->c_name && (cs->c_name[0] == '.' || cs->c_name[0] == '@')) + last_csect_name = cs->c_name; } continue; -- 1.6.5.rc2