From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1248 invoked by alias); 16 Mar 2012 11:20:23 -0000 Received: (qmail 1238 invoked by uid 22791); 16 Mar 2012 11:20:22 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.allinea.com (HELO mail.allinea.com) (94.125.131.200) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Mar 2012 11:20:09 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.allinea.com (Postfix) with ESMTP id 1612412E287; Fri, 16 Mar 2012 11:20:08 +0000 (GMT) Received: from mail.allinea.com ([127.0.0.1]) by localhost (mail.allinea.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id okUQATTpqQjQ; Fri, 16 Mar 2012 11:20:07 +0000 (GMT) Received: from [192.168.0.6] (cpc11-sotn9-2-0-cust158.15-1.cable.virginmedia.com [81.101.103.159]) (Authenticated sender: cjanuary) by mail.allinea.com (Postfix) with ESMTPSA id A89B112E226; Fri, 16 Mar 2012 11:20:07 +0000 (GMT) Message-ID: <1331896807.2787.3.camel@gumtree> Subject: Re: [PATCH] Fix incorrect use of strcpy. From: Chris January To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Fri, 16 Mar 2012 11:20:00 -0000 In-Reply-To: <874ntznej0.fsf@fleche.redhat.com> References: <1331216484.2742.7.camel@gumtree> <874ntznej0.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00600.txt.bz2 On Thu, 2012-03-08 at 11:17 -0700, Tom Tromey wrote: > >>>>> "Chris" == Chris January writes: > > Chris> The strings passed to strcpy may not overlap, but &p and &p[len + 1] > Chris> clearly do. memmove allows overlapping memory area. Ping for commit? > I think you should get started on your copyright assignment papers. > Your current patches are probably under the limit, but if you send more > then we'll need these. We have a company-wide assignment on file. Chris