From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 512 invoked by alias); 13 Mar 2012 15:17:53 -0000 Received: (qmail 502 invoked by uid 22791); 13 Mar 2012 15:17:51 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.allinea.com (HELO mail.allinea.com) (94.125.131.200) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Mar 2012 15:17:33 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.allinea.com (Postfix) with ESMTP id D725812E215; Tue, 13 Mar 2012 15:17:31 +0000 (GMT) Received: from mail.allinea.com ([127.0.0.1]) by localhost (mail.allinea.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BSHh6QgLhjp7; Tue, 13 Mar 2012 15:17:31 +0000 (GMT) Received: from [192.168.1.110] (unknown [94.125.131.195]) (Authenticated sender: cjanuary) by mail.allinea.com (Postfix) with ESMTPSA id 7311212E202; Tue, 13 Mar 2012 15:17:31 +0000 (GMT) Message-ID: <1331651851.2755.3.camel@gumtree> Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX. From: Chris January To: Joel Brobecker Cc: gdb-patches@sourceware.org Date: Tue, 13 Mar 2012 15:17:00 -0000 In-Reply-To: <20120312153016.GJ2853@adacore.com> References: <1331217037.2742.10.camel@gumtree> <20120309193904.GF2853@adacore.com> <1331541910.2783.2.camel@gumtree> <20120312153016.GJ2853@adacore.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00440.txt.bz2 On Mon, 2012-03-12 at 08:30 -0700, Joel Brobecker wrote: > > > > 2012-03-08 Chris January > > > > > > > > * stabsread.c (fix_common_block): Change type of valu argument > > > > to CORE_ADDR. > > > > > > This change looks correct to me too. Did you run the testsuite to > > > validate the change, by any chance? > > > > No, although there aren't any test cases in testsuite/gdb.fortran that > > use a common block anyway. > > The problem is that this potentially affects more than just Fortran > programs using common blocks. > > Would you have a GNU/Linux box available? You could test your change > a little differently, by running the testsuite with -gstabs+. I think > the following command should work: > > % make check RUNTESTFLAGS="--target_board % unix/gdb:debug_flags=-gstabs+" I ran the test suite on a GNU/Linux (SLES 10) PPC970 box. Four of the tests have intermittent failures (before and after the patch), but ignoring those there were no regressions. Chris