From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6371 invoked by alias); 12 Mar 2012 08:45:28 -0000 Received: (qmail 6363 invoked by uid 22791); 12 Mar 2012 08:45:27 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.allinea.com (HELO mail.allinea.com) (94.125.131.200) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Mar 2012 08:45:12 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.allinea.com (Postfix) with ESMTP id 1CA7C12E269; Mon, 12 Mar 2012 08:45:11 +0000 (GMT) Received: from mail.allinea.com ([127.0.0.1]) by localhost (mail.allinea.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b6F2mjDYP8QL; Mon, 12 Mar 2012 08:45:10 +0000 (GMT) Received: from [192.168.0.6] (cpc11-sotn9-2-0-cust158.15-1.cable.virginmedia.com [81.101.103.159]) (Authenticated sender: cjanuary) by mail.allinea.com (Postfix) with ESMTPSA id B5EF912E226; Mon, 12 Mar 2012 08:45:10 +0000 (GMT) Message-ID: <1331541910.2783.2.camel@gumtree> Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX. From: Chris January To: Joel Brobecker Cc: gdb-patches@sourceware.org Date: Mon, 12 Mar 2012 08:45:00 -0000 In-Reply-To: <20120309193904.GF2853@adacore.com> References: <1331217037.2742.10.camel@gumtree> <20120309193904.GF2853@adacore.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00388.txt.bz2 On Fri, 2012-03-09 at 11:39 -0800, Joel Brobecker wrote: > > The address of a Fortran common block may be >INT_MAX. fix_common_block > > should be using CORE_ADDR, not int. > > > > 2012-03-08 Chris January > > > > * stabsread.c (fix_common_block): Change type of valu argument > > to CORE_ADDR. > > This change looks correct to me too. Did you run the testsuite to > validate the change, by any chance? No, although there aren't any test cases in testsuite/gdb.fortran that use a common block anyway. > Do you have copyright assignment papers on file with the FSF? If not, > this change is sufficiently small that we can accept it, as well as > your other contribution ("Add another way of setting up [...]"). Yes, we have a company-wide assignment. Chris