From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3048 invoked by alias); 8 Mar 2012 18:42:45 -0000 Received: (qmail 3037 invoked by uid 22791); 8 Mar 2012 18:42:43 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 18:42:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 61C641C6AE7; Thu, 8 Mar 2012 13:42:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bwHljs4PWjqE; Thu, 8 Mar 2012 13:42:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2B7911C6A58; Thu, 8 Mar 2012 13:42:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E826B145615; Thu, 8 Mar 2012 10:42:22 -0800 (PST) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Joel Brobecker Subject: [RFA] Make breakpoint condition detection trace conditional on remote_debug. Date: Thu, 08 Mar 2012 18:42:00 -0000 Message-Id: <1331232142-10562-1-git-send-email-brobecker@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00282.txt.bz2 Hello, I am investigating a problem where a breakpoint with a condition no longer stops the program when running the program through gdbserver. One of the things I noticed is this message that keeps popping up in the gdbserver output: % gdbserver :4444 a Process a created; pid = 10100 Listening on port 4444 Remote debugging from host 127.0.0.1 Found breakpoint condition. Found breakpoint condition. Found breakpoint condition. This looks like a debugging trace that should only be enable if requested. What do you guys think of this patch. I'm a little under pressure, so I didn't test the patch, but I will if it looks correct. I wasn't sure whether I should have used debug_threads or remote_debug... gdb/gdbserver/ChangeLog: * server.c (process_point_options): If a conditional expression is found, only print a message if remote_debug is nonzero. Thanks, -- Joel --- gdb/gdbserver/server.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 586581c..3c97dbd 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -2908,7 +2908,8 @@ process_point_options (CORE_ADDR point_addr, char **packet) { case 'X': /* Conditional expression. */ - fprintf (stderr, "Found breakpoint condition.\n"); + if (remote_debug) + fprintf (stderr, "Found breakpoint condition.\n"); add_breakpoint_condition (point_addr, &dataptr); break; default: -- 1.7.1