Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.

Chris January
2012-03-13T15:17:53Z

On Mon, 2012-03-12 at 08:30 -0700, Joel Brobecker wrote:
> > > > 2012-03-08 Chris January <chris.january@allinea.com>
> > > >
> > > > * stabsread.c (fix_common_block): Change type of valu argument
> > > > to CORE_ADDR.
> > >
> > > This change looks correct to me too. Did you run the testsuite to
> > > validate the change, by any chance?
> >
> > No, although there aren't any test cases in testsuite/gdb.fortran that
> > use a common block anyway.
>
> The problem is that this potentially affects more than just Fortran
> programs using common blocks.
>
> Would you have a GNU/Linux box available? You could test your change
> a little differently, by running the testsuite with -gstabs+. I think
> the following command should work:
>
> % make check RUNTESTFLAGS="--target_board % unix/gdb:debug_flags=-gstabs+"

I ran the test suite on a GNU/Linux (SLES 10) PPC970 box. Four of the
tests have intermittent failures (before and after the patch), but
ignoring those there were no regressions.

Chris