Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX.

Joel Brobecker
2012-03-12T15:30:39Z

> > > 2012-03-08 Chris January <chris.january@allinea.com>
> > >
> > > * stabsread.c (fix_common_block): Change type of valu argument
> > > to CORE_ADDR.
> >
> > This change looks correct to me too. Did you run the testsuite to
> > validate the change, by any chance?
>
> No, although there aren't any test cases in testsuite/gdb.fortran that
> use a common block anyway.

The problem is that this potentially affects more than just Fortran
programs using common blocks.

Would you have a GNU/Linux box available? You could test your change
a little differently, by running the testsuite with -gstabs+. I think
the following command should work:

% make check RUNTESTFLAGS="--target_board % unix/gdb:debug_flags=-gstabs+"

The second issue that this raises is that it would be nice to have
one such testcase to detect future changes that might break this.
But given that this is stabs, and that stabs are on their last breath,
I am not going to insist on it this time around, especially if it is
going to take lots of time from you.

FYI: We, at AdaCore, switch to DWARF on AIX last year. We had to move
to GNU ld for that. One thing I have to say, we're not sorry to be rid
of stabs.

> > Do you have copyright assignment papers on file with the FSF? If not,
> > this change is sufficiently small that we can accept it, as well as
> > your other contribution ("Add another way of setting up [...]").
>
> Yes, we have a company-wide assignment.

OK, found it! Thanks...

--
Joel