From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 325 invoked by alias); 6 Mar 2012 20:15:00 -0000 Received: (qmail 316 invoked by uid 22791); 6 Mar 2012 20:14:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailrelay012.isp.belgacom.be (HELO mailrelay012.isp.belgacom.be) (195.238.6.179) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Mar 2012 20:14:42 +0000 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAD1vVk9R9oZK/2dsb2JhbAAMN4U0skkBAQEEI1YQCw4KAgImAgJXBq83kjWBL44ZgRYEpVWCZA Received: from 74.134-246-81.adsl-dyn.isp.belgacom.be (HELO [192.168.1.3]) ([81.246.134.74]) by relay.skynet.be with ESMTP; 06 Mar 2012 21:14:40 +0100 Subject: Re: [patch] Fix PR 13392 : check offset of JMP insn From: Philippe Waroquiers To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org In-Reply-To: <4F56434F.4030107@redhat.com> References: <4F561363.4070702@codesourcery.com> <4F56434F.4030107@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 06 Mar 2012 20:15:00 -0000 Message-ID: <1331064879.2209.11.camel@soleil> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00205.txt.bz2 On Tue, 2012-03-06 at 17:03 +0000, Pedro Alves wrote: > We should send an error back to GDB with "E." instead of printing something > to gdbserver's console, and leaving the user with a generic and > unhelful error. "4-byte" isn't strictly correct, as this is a signed > offset, and I think we can be a bit more clear. So we end up with: > > sprintf (err, > "E.Jump back from jump pad too far from tracepoint " > "(offset 0x%" PRIx64 " > int32).", loffset); > In the gdb protocol documentation, all error replies but one are described as E NN. Some of them specifies that NN are hex digits. The exception is the packet qTMinFTPILen: the error reply is described as only an E (this last sentence intentionnally not finished with a . :). Is there somewhere a description of what an E. packet is, and when this is allowed ? Philippe