From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21358 invoked by alias); 2 Feb 2012 22:13:13 -0000 Received: (qmail 21345 invoked by uid 22791); 2 Feb 2012 22:13:11 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailrelay006.isp.belgacom.be (HELO mailrelay006.isp.belgacom.be) (195.238.6.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Feb 2012 22:12:56 +0000 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAGkJK09R9py4/2dsb2JhbAAMN4ULrH4BAQEDASMEVwslAiYCAlcGE4d8pieRfIEviiIBEAEJBAQFAQIGAQEBRYZogRYEp3k Received: from 184.156-246-81.adsl-dyn.isp.belgacom.be (HELO [192.168.1.3]) ([81.246.156.184]) by relay.skynet.be with ESMTP; 02 Feb 2012 23:12:55 +0100 Subject: (ping) Re: RFA: remote.c : allow long monitor cmds + allow user to C-c From: Philippe Waroquiers To: "gdb-patches@sourceware.org ml" In-Reply-To: References: <1327265676.23561.25.camel@soleil> <4F1D5335.3090705@redhat.com> <1327350423.2215.6.camel@soleil> Content-Type: text/plain; charset="UTF-8" Date: Thu, 02 Feb 2012 22:13:00 -0000 Message-ID: <1328220784.7612.5.camel@soleil> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00042.txt.bz2 On Tue, 2012-01-24 at 01:48 -0200, Sergio Durigan Junior wrote: > Some formatting nits. Fixed in the updated patch below. > I know almost nothing about this part of the code, but as far as I have > seen, the patch looks OK. I am not a maintainer, however. RFA ping ? Thanks Philippe Index: gdb/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.13804 diff -u -p -r1.13804 ChangeLog --- gdb/ChangeLog 2 Feb 2012 20:19:02 -0000 1.13804 +++ gdb/ChangeLog 2 Feb 2012 22:05:35 -0000 @@ -1,3 +1,8 @@ +2012-02-02 Philippe Waroquiers + + * remote.c (remote_rcmd): Use getpkt_sane to detect timeout + and continue the loop. Add QUIT statement. + 2012-02-02 Doug Evans * blockframe.c (find_pc_partial_function_gnu_ifunc): Change type of Index: gdb/remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.481 diff -u -p -r1.481 remote.c --- gdb/remote.c 2 Feb 2012 18:04:29 -0000 1.481 +++ gdb/remote.c 2 Feb 2012 22:05:36 -0000 @@ -8590,8 +8590,17 @@ remote_rcmd (char *command, char *buf; /* XXX - see also remote_get_noisy_reply(). */ + QUIT; /* Allow user to bail out with ^C. */ rs->buf[0] = '\0'; - getpkt (&rs->buf, &rs->buf_size, 0); + if (getpkt_sane (&rs->buf, &rs->buf_size, 0) == -1) + { + /* Timeout. Continue to (try to) read responses. + This is better than stopping with an error, assuming the stub + is still executing the (long) monitor command. + If needed, the user can interrupt gdb using C-c, obtaining + an effect similar to stop on timeout. */ + continue; + } buf = rs->buf; if (buf[0] == '\0') error (_("Target does not support this command."));