From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23745 invoked by alias); 29 Dec 2011 20:34:06 -0000 Received: (qmail 23681 invoked by uid 22791); 29 Dec 2011 20:34:05 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Dec 2011 20:33:51 +0000 Received: from /spool/local by e24smtp05.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 29 Dec 2011 18:33:49 -0200 Received: from d24relay01.br.ibm.com ([9.8.31.16]) by e24smtp05.br.ibm.com ([10.172.0.141]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 29 Dec 2011 18:33:48 -0200 Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBTKUXBf3469358 for ; Thu, 29 Dec 2011 17:30:33 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBTKXXSr007457 for ; Thu, 29 Dec 2011 18:33:34 -0200 Received: from emachado.ibm.com ([9.8.11.206]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pBTKXX2G007444 for ; Thu, 29 Dec 2011 18:33:33 -0200 From: Edjunior Barbosa Machado To: gdb-patches@sourceware.org Subject: [PATCH] minor fixes for python finish breakpoint testcases Date: Thu, 29 Dec 2011 21:51:00 -0000 Message-Id: <1325190816-15407-1-git-send-email-emachado@linux.vnet.ibm.com> x-cbid: 11122920-2362-0000-0000-000005E249AA X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00893.txt.bz2 Hi, this patch fixes some minor issues found on these 2 new testcases. For py-finish-breakpoint.exp, it expects the leading `.' found on ppc64's symbols and adds the newline missing at the end of file. For py-finish-breakpoint2.exp, it skips the tests if python support is not enabled. BTW, py-finish-breakpoint2.exp still shows some failures on ppc64 when python support is enabled but I still haven't figured out what is the problem. FAIL: gdb.python/py-finish-breakpoint2.exp: check FinishBreakpoint in catch() FAIL: gdb.python/py-finish-breakpoint2.exp: check finish BP removal FAIL: gdb.python/py-finish-breakpoint2.exp: continue to second exception FAIL: gdb.python/py-finish-breakpoint2.exp: set FinishBP after the exception Thanks, -- Edjunior 2011-12-29 Edjunior Machado gdb/testsuite/ * gdb.python/py-finish-breakpoint.exp: Add `.' prefix for ppc64. Add newline at end of file. * gdb.python/py-finish-breakpoint2.exp: Skip testcase if python support is not enabled. diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp index c7a42a2..42488ba 100644 --- a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp @@ -118,7 +118,8 @@ if ![runto_main] then { gdb_test "print do_nothing" "no debug info.*" "ensure that shared lib has no debug info" gdb_breakpoint "do_nothing" {temporary} -gdb_test "continue" "Temporary breakpoint .*in do_nothing.*" "continue to do_nothing" +gdb_test "continue" "Temporary breakpoint .*in \\.?do_nothing.*" \ + "continue to do_nothing" gdb_test "python finishBP = SimpleFinishBreakpoint(gdb.newest_frame())" \ "SimpleFinishBreakpoint init" \ @@ -262,4 +263,4 @@ if ![runto "test_exec_exit"] then { gdb_test_no_output "set var do_exit = 0" "switch to execve() test" gdb_test "python SimpleFinishBreakpoint(gdb.newest_frame())" "SimpleFinishBreakpoint init" "set FinishBP after the exec" gdb_test "catch exec" "Catchpoint.*\(exec\).*" "catch exec" -gdb_test "continue" "SimpleFinishBreakpoint out of scope.*" "catch out of scope after exec" \ No newline at end of file +gdb_test "continue" "SimpleFinishBreakpoint out of scope.*" "catch out of scope after exec" diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint2.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint2.exp index 433d1e6..451cc90 100644 --- a/gdb/testsuite/gdb.python/py-finish-breakpoint2.exp +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint2.exp @@ -38,6 +38,9 @@ gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_load ${binfile} +# Skip all tests if Python scripting is not enabled. +if { [skip_python_tests] } { continue } + if ![runto_main] then { fail "Cannot run to main." return 0