From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85990-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31945 invoked by alias); 9 Dec 2011 19:23:21 -0000
Received: (qmail 31937 invoked by uid 22791); 9 Dec 2011 19:23:20 -0000
X-SWARE-Spam-Status: No, hits=-3.1 required=5.0	tests=BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail3.caviumnetworks.com (HELO mail3.caviumnetworks.com) (12.108.191.235)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Dec 2011 19:23:05 +0000
Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378)	id <B4ee260710000>; Fri, 09 Dec 2011 11:24:33 -0800
Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 9 Dec 2011 11:23:05 -0800
Received: from [10.18.104.76] ([64.2.3.195]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 9 Dec 2011 11:23:04 -0800
Subject: Re: [PATCH] Fix linespec.c vs padding on 32bit targets
From: Andrew Pinski <andrew.pinski@cavium.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
In-Reply-To: <m3y5ulg3db.fsf@fleche.redhat.com>
References:	 <CA+=Sn1km=U-HzHLednrV0V5d5eZ9gjqFOgcpRmgaryVd_=TSyg@mail.gmail.com>	 <m3y5ulg3db.fsf@fleche.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 09 Dec 2011 19:53:00 -0000
Message-ID: <1323458584.351.544.camel@apinskidesktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00309.txt.bz2

On Fri, 2011-12-09 at 07:40 -0800, Tom Tromey wrote:
> >>>>> "Andrew" == Andrew Pinski <andrew.pinski@caviumnetworks.com> writes:
> 
> Andrew>   The problem here is there is padding in address_entry so
> Andrew> iterative_hash_object on the full object cannot be done as the padding
> Andrew> would be some junk.  This causes lots of gdb failures on
> Andrew> mips64-linux-gnu.
> 
> Thanks Andrew.
> 
> Andrew> OK?  Tested on mips64-linux-gnu.
> 
> One tiny nit, see below.
> 
> Andrew> PS I don't have write access for gdb.
> 
> If you have write access to binutils then you do.
> If you still don't, let me know and I will commit it.
> 
> Andrew> +  hashval_t hash;
> Andrew> +  hash = iterative_hash_object (aep->pspace, 0);
> Andrew> +  return iterative_hash_object (aep->addr, hash);
> 
> The gdb style puts a blank line between declarations and code.
> Ok with that change.

Thanks I committed the patch.

Thanks,
Andrew Pinski