From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24371 invoked by alias); 17 Oct 2011 15:07:20 -0000 Received: (qmail 24362 invoked by uid 22791); 17 Oct 2011 15:07:18 -0000 X-SWARE-Spam-Status: No, hits=0.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nm14.bullet.mail.sp2.yahoo.com (HELO nm14.bullet.mail.sp2.yahoo.com) (98.139.91.84) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Mon, 17 Oct 2011 15:07:00 +0000 Received: from [98.139.91.66] by nm14.bullet.mail.sp2.yahoo.com with NNFMP; 17 Oct 2011 15:07:00 -0000 Received: from [98.139.91.29] by tm6.bullet.mail.sp2.yahoo.com with NNFMP; 17 Oct 2011 15:07:00 -0000 Received: from [127.0.0.1] by omp1029.mail.sp2.yahoo.com with NNFMP; 17 Oct 2011 15:06:59 -0000 Received: (qmail 12166 invoked by uid 60001); 17 Oct 2011 15:06:59 -0000 Received: from [122.172.174.48] by web36107.mail.mud.yahoo.com via HTTP; Mon, 17 Oct 2011 08:06:59 PDT Message-ID: <1318864019.4594.YahooMailClassic@web36107.mail.mud.yahoo.com> Date: Mon, 17 Oct 2011 15:42:00 -0000 From: chandra krishnappa Subject: Re: [PATCH] arm reversible : To: Yao Qi , oza Pawandeep Cc: gdb-patches@sourceware.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00466.txt.bz2 Hi Yao and Oza, Thanks for your comments and hints.. Yes, I wish to try test and submit tes= t scripts soon. some hurdles to find time for testing.. will sort out and s= ubmit as soon as possible.. Thanks & Regards, -Chandra K --- On Mon, 10/17/11, oza Pawandeep wrote: > From: oza Pawandeep > Subject: Re: [PATCH] arm reversible : > To: "Yao Qi" > Cc: gdb-patches@sourceware.org > Date: Monday, October 17, 2011, 9:55 AM > Hi Yao, >=20 > Thanks for your comments. please find my comments below. >=20 > 1) > Yao:=C2=A0 x86 assembly will not compiled and run for arm > target, so they don't > > make fails here.=C2=A0 Beside these fails, I find > there are some GDB internal > > errors in test result >=20 > Oza: what I meant here was: x86 assembly might have failed > to compile > even and gdb test results might be including that. > anyway, arm assembly has to be written separately, which I > guess > Chandra K. might be doing. >=20 > 2) > Yao: > Looks like most of indentaiton of your 2nd line of comment > is incorrect. > I'll point some of them out, but I may miss some. >=20 > I suggest that you can find some good editor which can > highlight > trailing spaces and too-long line easily. >=20 > Oza: this is one thing I have been struggling with, I have > been moving > this patch back and forth from windows to linux and using > source insight, vi, xemacs > an d finally when I paste it to google mail the space gets > distorted. > I need to find out what I can do. > sorry about repeating space mistakes. >=20 > 3) Yes, only 16-bit thumb is supported, but you should > report a warning or > error when encounter a 32-bit thumb insn, and skip > it.=C2=A0 In > arm_process_record, you assume that all thumb insns are > 16-bit, which is > not correct.=C2=A0 Please reference > "thumb_process_displaced_insn". >=20 > Oza: I will include this logic. >=20 > 4) Yao: > I don't understand why coproc insn is not handled for > process record > here.=C2=A0 is it in phase_3? >=20 > Oza: initially I had planned to put both coprocessor and > arm_extension_space insn in phase 3. > but I am going to update this patch with > arm__extension_space insn atleast. >=20 > as far as coprocessor insns are concerned, I could not find > any API > which could be used to read coprocessor register values. > I had sent email regarding the same long back: but I did > not get > response, so I moved it to phase 3. >=20 > If you could point me out the way to read coprocessor > register values: > I will try to implement on phase 2. >=20 > Thanks Yao, > Regards, > Oza. >=20 >=20 >=20 >=20 >=20 > On Mon, Oct 17, 2011 at 7:25 AM, Yao Qi > wrote: > > On 10/16/2011 12:34 AM, oza Pawandeep wrote: > >> Hi Yao, > >> > >> first of all thank you for your comments, will be > sending the patch > >> soon with your comments incorporated as much as > possible. > >> thank you again for sending test results; > >> > >> I suppose failed test case might be including > >> > >> 1) system call support > >> 2) signal support > >> 3) any other linux ABI support > >> 4) there are some programs on x86 assembly which > needs to be written > >> for ARM and put separately. > > > > x86 assembly will not compiled and run for arm target, > so they don't > > make fails here. =C2=A0Beside these fails, I find there > are some GDB internal > > errors in test result: > > > > stepi^M > > ../../gdb/gdb/breakpoint.c:12523: internal-error: > > insert_single_step_breakpoint: Assertion > `single_step_breakpoints[1] =3D=3D > > NULL' failed. > > > > stepi^M > > ../../gdb/gdb/infrun.c:1804: internal-error: resume: > Assertion > > `!(singlestep_breakpoints_inserted_p && step)' > failed. > > > > -- > > Yao (=E9=BD=90=E5=B0=A7) > > >