From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-140066-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11387 invoked by alias); 25 Jun 2017 11:25:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11322 invoked by uid 89); 25 Jun 2017 11:25:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Jun 2017 11:24:58 +0000
Received: by simark.ca (Postfix, from userid 33)	id 0885F1E561; Sun, 25 Jun 2017 07:24:57 -0400 (EDT)
To: Doug Gilmore <Doug.Gilmore@imgtec.com>
Subject: Re: [PATCH] Fix PR 21337 (v3): segfault when re-reading symbols with  remote debugging.
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Sun, 25 Jun 2017 11:25:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
In-Reply-To: <5c33519c-6345-3cc8-2fa8-054a3b80bfb6@imgtec.com>
References: <d7619e0c-38f4-b547-8117-8e5315313b71@imgtec.com> <a869bc5c-a685-d9f1-1f28-aafcde8c3e1d@codesourcery.com> <20511c76-c816-d31d-5144-749eac9fc470@imgtec.com> <3c5ce0a0-72e5-4460-5555-ad2214866260@imgtec.com> <5c494cc147f71dd8246572aa0b815c9f@polymtl.ca> <fddf3219-1de7-09ca-517c-7d68b34e878d@imgtec.com> <7e9595026acbfd2f1a7bff321fa255e1@polymtl.ca> <d266f2a4-5482-6178-f4fd-9280e27757b4@imgtec.com> <5b5cc0a61e434a3406cbb25c16b8a550@polymtl.ca> <f6d52471-afdf-575f-488a-5ca9c2cb1158@imgtec.com> <e1620878165275e22429dbb746d40932@polymtl.ca> <f431263b-02f6-67f8-29df-753f367c2ebf@imgtec.com> <28fcce08-cab6-1e63-80d7-1d61c688cc10@imgtec.com> <09492e58ce0daf1efee14636bc5312cc@polymtl.ca> <5c33519c-6345-3cc8-2fa8-054a3b80bfb6@imgtec.com>
Message-ID: <1314dbb1177c39791e5f7a5d51c13089@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.5
X-IsSubscribed: yes
X-SW-Source: 2017-06/txt/msg00686.txt.bz2

Hi Doug,

Good thing you pinged, I had completely missed it, sorry for the wait.

+gdb_test "source $gdbfile" ".*source-command-completed.*" \
+    "source $testfile.gdb"
+# Sometimes the failure only occurs on the second invocation.
+gdb_test "source $gdbfile" ".*source-command-completed.*" \
+    "source $testfile.gdb"

Tests should have unique names, so that when one fails, you know easily 
which one.  So, perhaps "source $testfile.gdb 1" and "source 
$testfile.gdb 2"?

The patch is ok with this fixed.

Thanks,

Simon