Re: [PATCH 4/7] [python] API for macros: Add methods to get a gdb.Macro.

Phil Muldoon
2011-08-30T20:28:36Z

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> I think this should return a Tuple. Tuples are immutable, and unless
> Phil> you for see a use for the user to manipulate the List, we should guard
> Phil> against it. If you agree, please alter stpy_macros too.
>
> Using a tuple means you have to iterate twice -- once to count the
> objects and once to make the tuple.

You can use a list, and then convert it to a tuple:

PyList_AsTuple

We already use the above.

If you wanted to, you could use PyTuple_Ruse, as long as there is
one reference to the tuple. But building as a list, and returning as a
tuple seems reasonable to me.

Cheers

Phil