From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30540 invoked by alias); 6 Jul 2011 18:16:08 -0000 Received: (qmail 30524 invoked by uid 22791); 6 Jul 2011 18:16:07 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 18:15:53 +0000 Received: from /spool/local by e24smtp05.br.ibm.com with XMail ESMTP for from ; Wed, 6 Jul 2011 15:15:44 -0300 Received: from mailhub3.br.ibm.com ([9.18.232.110]) by e24smtp05.br.ibm.com ([10.172.0.141]) with XMail ESMTP; Wed, 6 Jul 2011 15:15:33 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p66IHJP0913470 for ; Wed, 6 Jul 2011 15:17:26 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p66IFArK008869 for ; Wed, 6 Jul 2011 15:15:11 -0300 Received: from [9.8.2.151] ([9.8.2.151]) by d24av02.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p66IFATg008838; Wed, 6 Jul 2011 15:15:10 -0300 Subject: Re: [RFA] Make ppc-linux-nat insert/remove breakpoint and watchpoint functions return -1. From: Thiago Jung Bauermann To: Joel Brobecker Cc: Tom Tromey , gdb-patches ml In-Reply-To: <20110706163507.GA29308@adacore.com> References: <1309897267.3634.6.camel@hactar> <20110706161150.GD2407@adacore.com> <20110706163507.GA29308@adacore.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 06 Jul 2011 19:38:00 -0000 Message-ID: <1309976103.13220.3.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11070618-2362-0000-0000-0000041D26BB X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00209.txt.bz2 On Wed, 2011-07-06 at 09:35 -0700, Joel Brobecker wrote: > > Looking at target.h: > > > > | /* Insert a breakpoint at address BP_TGT->placed_address in the target > > | machine. Result is 0 for success, or an errno value. */ > > | > > | extern int target_insert_breakpoint (struct gdbarch *gdbarch, > > | struct bp_target_info *bp_tgt); > > > > Sorry, scrap that part - I was looking at the wrong method > (I should have been looking at the `hw' one....). > > > That being said, it's ultra important IMO in that case that we add the > > documentation wherever missing, because these are used by all ports. > > Makes that comment all the more relevant :). > > So I guess we'll have to infer the expected behavior from the core > code that calls it. I am hoping that it's the same as with the non > hw versions! :) My ppc476 patches touched a lot of this code and I made everything that uses the breakpoint_ops methods follow that convention. Things were indeed confusing and even contradictory before my patches, and I thought I fixed all that. It seems I missed some parts then. I'll have a look and post fixes. This patch can wait for now. Thanks for bringing this up. -- []'s Thiago Jung Bauermann IBM Linux Technology Center