From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21585 invoked by alias); 4 Jul 2011 19:32:35 -0000 Received: (qmail 21576 invoked by uid 22791); 4 Jul 2011 19:32:34 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 19:32:20 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with XMail ESMTP for from ; Mon, 4 Jul 2011 16:32:13 -0300 Received: from mailhub1.br.ibm.com ([9.18.232.109]) by e24smtp04.br.ibm.com ([10.172.0.140]) with XMail ESMTP; Mon, 4 Jul 2011 16:32:11 -0300 Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p64JYDts1142934 for ; Mon, 4 Jul 2011 16:34:13 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p64JW8se000979 for ; Mon, 4 Jul 2011 16:32:08 -0300 Received: from [9.8.1.40] ([9.8.1.40]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p64JW8Cr000935 for ; Mon, 4 Jul 2011 16:32:08 -0300 Subject: [RFC] s/preceed/precede/ From: Thiago Jung Bauermann To: gdb-patches ml Content-Type: text/plain; charset="UTF-8" Date: Mon, 04 Jul 2011 19:38:00 -0000 Message-ID: <1309807927.4471.12.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11070419-8936-0000-0000-000003B845EA X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00115.txt.bz2 Hi, (From the "I should be spending my time in my priority tasks" series.) It looks like "preceed" is wrong and "precede" is right. I can't find "preceed" in neither Merriam-Webster nor dictionary.com. Also, there are many places using "precede" in GDB's source code. But "preceed" is so common that I'm not so sure about this patch. Perhaps it's just an alternative spelling? -- []'s Thiago Jung Bauermann IBM Linux Technology Center 2011-07-04 Thiago Jung Bauermann gdb/ * ada-lang.c: Fix typos. * amd64-tdep.c: Likewise. * breakpoint.c: Likewise. * cli/cli-decode.c: Likewise. * findcmd.c: Likewise. * inline-frame.c: Likewise. * mi/mi-main.c: Likewise. * minsyms.c: Likewise. * monitor.c: Likewise. * monitor.h: Likewise. * prologue-value.c: Likewise. * reverse.c: Likewise. * s390-tdep.c: Likewise. gdb/testsuite/ * gdb.base/call-sc.c: Likewise. * gdb.base/ifelse.exp: Likewise. * gdb.base/structs.c: Likewise. gdb/doc/ * gdb.texinfo: Likewise. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 752af87..4499873 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -8321,7 +8321,7 @@ ada_enum_name (const char *name) /* First, unqualify the enumeration name: 1. Search for the last '.' character. If we find one, then skip - all the preceeding characters, the unqualified name starts + all the preceding characters, the unqualified name starts right after that dot. 2. Otherwise, we may be debugging on a target where the compiler translates dots into "__". Search forward for double underscores, diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c index 4524f03..de62ac7 100644 --- a/gdb/amd64-tdep.c +++ b/gdb/amd64-tdep.c @@ -518,7 +518,7 @@ amd64_classify_aggregate (struct type *type, enum amd64_reg_class class[2]) if (class[0] == AMD64_MEMORY || class[1] == AMD64_MEMORY) class[0] = class[1] = AMD64_MEMORY; - /* Rule (b): If SSEUP is not preceeded by SSE, it is converted to + /* Rule (b): If SSEUP is not preceded by SSE, it is converted to SSE. */ if (class[0] == AMD64_SSEUP) class[0] = AMD64_SSE; diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index eae337e..802c8a1 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -8775,7 +8775,7 @@ break_range_command (char *arg, int from_tty) end = find_breakpoint_range_end (sal_end); if (sal_start.pc > end) - error (_("Invalid address range, end preceeds start.")); + error (_("Invalid address range, end precedes start.")); length = end - sal_start.pc + 1; if (length < 0) diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index 33dc966..744d52e 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -1500,7 +1500,7 @@ deprecated_cmd_warning (char **text) If LINE refers to an alias, *alias will point to that alias. - If LINE is a postfix command (i.e. one that is preceeded by a prefix + If LINE is a postfix command (i.e. one that is preceded by a prefix command) set *prefix_cmd. Set *cmd to point to the command LINE indicates. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index dbaf30e..129a46b 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -36715,7 +36715,7 @@ The register's size, in bits. @item regnum The register's number. If omitted, a register's number is one greater than that of the previous register (either in the current feature or in -a preceeding feature); the first register in the target description +a preceding feature); the first register in the target description defaults to zero. This register number is used to read or write the register; e.g.@: it is used in the remote @code{p} and @code{P} packets, and registers appear in the @code{g} and @code{G} packets diff --git a/gdb/findcmd.c b/gdb/findcmd.c index 0255613..7665a04 100644 --- a/gdb/findcmd.c +++ b/gdb/findcmd.c @@ -151,7 +151,7 @@ parse_find_args (char *args, ULONGEST *max_countp, v = parse_to_comma_and_eval (&s); end_addr = value_as_address (v); if (start_addr > end_addr) - error (_("Invalid search space, end preceeds start.")); + error (_("Invalid search space, end precedes start.")); search_space_len = end_addr - start_addr + 1; /* We don't support searching all of memory (i.e. start=0, end = 0xff..ff). diff --git a/gdb/inline-frame.c b/gdb/inline-frame.c index dc05b8a..6298594 100644 --- a/gdb/inline-frame.c +++ b/gdb/inline-frame.c @@ -288,7 +288,7 @@ block_starting_point_at (CORE_ADDR pc, struct block *block) if (new_block == block || contained_in (new_block, block)) return 0; - /* The immediately preceeding address belongs to a different block, + /* The immediately preceding address belongs to a different block, which is not a child of this one. Treat this as an entrance into BLOCK. */ return 1; diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 7592a74..1634778 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -1550,7 +1550,7 @@ mi_cmd_data_read_memory_bytes (char *command, char **argv, int argc) /* DATA-MEMORY-WRITE: - COLUMN_OFFSET: optional argument. Must be preceeded by '-o'. The + COLUMN_OFFSET: optional argument. Must be preceded by '-o'. The offset from the beginning of the memory grid row where the cell to be written is. ADDR: start address of the row in the memory grid where the memory diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 249675b..70871cd 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -583,7 +583,7 @@ lookup_minimal_symbol_by_pc_section_1 (CORE_ADDR pc, /* If we are looking for a trampoline and this is a text symbol, or the other way around, check the - preceeding symbol too. If they are otherwise + preceding symbol too. If they are otherwise identical prefer that one. */ if (hi > 0 && MSYMBOL_TYPE (&msymbol[hi]) == other_type diff --git a/gdb/monitor.c b/gdb/monitor.c index 90f36d9..2eeb705 100644 --- a/gdb/monitor.c +++ b/gdb/monitor.c @@ -1864,7 +1864,7 @@ monitor_read_memory (CORE_ADDR memaddr, char *myaddr, int len) len = min (len, 16); - /* Some dumpers align the first data with the preceeding 16 + /* Some dumpers align the first data with the preceding 16 byte boundary. Some print blanks and start at the requested boundary. EXACT_DUMPADDR */ diff --git a/gdb/monitor.h b/gdb/monitor.h index 0e9cae3..77691c3 100644 --- a/gdb/monitor.h +++ b/gdb/monitor.h @@ -226,7 +226,7 @@ struct monitor_ops #define MO_PRINT_PROGRAM_OUTPUT 0x200000 -/* Some dump bytes commands align the first data with the preceeding +/* Some dump bytes commands align the first data with the preceding 16 byte boundary. Some print blanks and start at the exactly the requested boundary. */ diff --git a/gdb/prologue-value.c b/gdb/prologue-value.c index 46c5b68..0704787 100644 --- a/gdb/prologue-value.c +++ b/gdb/prologue-value.c @@ -399,7 +399,7 @@ pv_area_store_would_trash (struct pv_area *area, pv_t addr) This may return zero, if AREA has no entries. And since the entries are a ring, this may return an entry that - entirely preceeds OFFSET. This is the correct behavior: depending + entirely precedes OFFSET. This is the correct behavior: depending on the sizes involved, we could still overlap such an area, with wrap-around. */ static struct area_entry * diff --git a/gdb/reverse.c b/gdb/reverse.c index b44c0d1..1437b40 100644 --- a/gdb/reverse.c +++ b/gdb/reverse.c @@ -184,7 +184,7 @@ delete_one_bookmark (int num) if (b == bookmark_chain) bookmark_chain = b->next; - /* Find bookmark preceeding "marked" one, so we can unlink. */ + /* Find bookmark preceding "marked" one, so we can unlink. */ if (b) { ALL_BOOKMARKS (b1) diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c index d9407ef..ca7ecc7 100644 --- a/gdb/s390-tdep.c +++ b/gdb/s390-tdep.c @@ -1307,7 +1307,7 @@ s390_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc) exactly one case: when pc points to that branch instruction. Thus we try to disassemble the one instructions immediately - preceeding pc and check whether it is an LM-type instruction + preceding pc and check whether it is an LM-type instruction modifying the stack pointer. Note that disassembling backwards is not reliable, so there diff --git a/gdb/testsuite/gdb.base/call-sc.c b/gdb/testsuite/gdb.base/call-sc.c index 99810af..951e101 100644 --- a/gdb/testsuite/gdb.base/call-sc.c +++ b/gdb/testsuite/gdb.base/call-sc.c @@ -68,7 +68,7 @@ int main() /* An infinite loop that first clears all the variables and then calls the function. This "hack" is to make re-testing easier - - "advance fun" is guaranteed to have always been preceeded by a + "advance fun" is guaranteed to have always been preceded by a global variable clearing zed call. */ zed (); diff --git a/gdb/testsuite/gdb.base/ifelse.exp b/gdb/testsuite/gdb.base/ifelse.exp index 0a0bb0a..adf23e7 100644 --- a/gdb/testsuite/gdb.base/ifelse.exp +++ b/gdb/testsuite/gdb.base/ifelse.exp @@ -53,7 +53,7 @@ gdb_test_multiple "if 0\nend" $message { # This fails in GDB <=6.5 # Unfortunately it was an uninitialised memory problem so -# sometimes it just works. Preceed it with an if else end with +# sometimes it just works. Precede it with an if else end with # bodies and hopefully the memory with be dirty and the problem # will show itself (this works at time of writing). diff --git a/gdb/testsuite/gdb.base/structs.c b/gdb/testsuite/gdb.base/structs.c index d688cd0..c26b86c 100644 --- a/gdb/testsuite/gdb.base/structs.c +++ b/gdb/testsuite/gdb.base/structs.c @@ -433,7 +433,7 @@ int main() /* An infinite loop that first clears all the variables and then calls each function. This "hack" is to make testing random functions easier - "advance funN" is guaranteed to have always - been preceeded by a global variable clearing zed call. */ + been preceded by a global variable clearing zed call. */ while (1) {