From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48007 invoked by alias); 21 Jul 2017 20:49:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47382 invoked by uid 89); 21 Jul 2017 20:48:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1067 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jul 2017 20:48:49 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v6LKmLZE029933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Jul 2017 16:48:26 -0400 Received: by simark.ca (Postfix, from userid 112) id DE88C1E5B6; Fri, 21 Jul 2017 16:48:21 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 900BC1E194; Fri, 21 Jul 2017 16:48:20 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 21 Jul 2017 20:49:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA v2 4/4] Use std::vector in struct catch_syscall_inferior_data In-Reply-To: <20170719203225.6714-5-tom@tromey.com> References: <20170719203225.6714-1-tom@tromey.com> <20170719203225.6714-5-tom@tromey.com> Message-ID: <1305eee7196c2c59d8e79c72d6c7cd37@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 21 Jul 2017 20:48:22 +0000 X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00324.txt.bz2 On 2017-07-19 22:32, Tom Tromey wrote: > @@ -104,31 +106,17 @@ insert_catch_syscall (struct bp_location *bl) > { > int elem; > > - if (iter >= VEC_length (int, inf_data->syscalls_counts)) > - { > - int old_size = VEC_length (int, > inf_data->syscalls_counts); > - uintptr_t vec_addr_offset > - = old_size * ((uintptr_t) sizeof (int)); > - uintptr_t vec_addr; > - VEC_safe_grow (int, inf_data->syscalls_counts, iter + > 1); > - vec_addr = ((uintptr_t) VEC_address (int, > - inf_data->syscalls_counts) > - + vec_addr_offset); > - memset ((void *) vec_addr, 0, > - (iter + 1 - old_size) * sizeof (int)); > - } > - elem = VEC_index (int, inf_data->syscalls_counts, iter); > - VEC_replace (int, inf_data->syscalls_counts, iter, ++elem); > + if (iter >= inf_data->syscalls_counts.size ()) > + inf_data->syscalls_counts.resize (iter + 1); I wasn't sure at first if this would insert zeros, but after some searching it seems like the new elements are value-initialized, so it's fine. LGTM too. Simon