Re: [RFA 2/3] Demote to sw watchpoint only in update_watchpoint

Eli Zaretskii
2011-05-04T03:07:56Z

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org,
> uweigand@de.ibm.com
> Date: Tue, 03 May 2011 21:03:06 -0300
>
> On Tue, 2011-05-03 at 23:29 +0300, Eli Zaretskii wrote:
> > > From: Pedro Alves <pedro@codesourcery.com>
> > > Date: Tue, 3 May 2011 19:12:42 +0100
> > > Cc: bauerman@br.ibm.com,
> > > uweigand@de.ibm.com
> > >
> > > I'm proposing getting rid of target_can_use_hardware_watchpoint
> > > as being part of the core accounting infrastructure.
> >
> > I'm fine with heading that way. It will certainly be cleaner than the
> > current mess, which needs a face-lift every few months.
>
> For this scheme to work, GDB will have to be changed to use
> always-inserted mode exclusively, right? Or at least insert all
> breakpoints and watchpoints when probing whether a new
> breakpoint/watchpoint can be created.

I think what Pedro suggests can (and should) work only for hardware
watchpoints and breakpoints. Normal breakpoints and watchpoints
cannot work that way, they must be inserted at "resume" time.

So I think always-inserted mode is not the right way here, unless I'm
missing something.