Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [patch][branch] Fix "save breakpoints" for watchpoints
Date: Fri, 08 Apr 2011 20:42:00 -0000	[thread overview]
Message-ID: <1302295317.2074.9.camel@hactar> (raw)

Hi,

When I converted watchpoints to use the breakpoint_ops struct, I
inadvertently broke saving watchpoints to a file, because
save_breakpoints doesn't check whether tp->ops->print_recreate is NULL
before calling it (as is customary before calling breakpoint_ops
methods). This results in a segfault since I didn't provide an
implementation for that method for watchpoints (save_breakpoints is
capable of dealing with watchpoints). This simple patch fixes the bug.

No regressions on i386-linux. Ok for HEAD and the branch?


[0] - http://sourceware.org/ml/gdb-patches/2011-01/msg00228.html
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


2011-04-08  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* breakpoint.c (save_breakpoints): Verify whether
	breakpoint_ops.print_recreate is defined before calling it.

Index: gdb.git/gdb/breakpoint.c
===================================================================
--- gdb.git.orig/gdb/breakpoint.c	2011-04-08 16:09:31.000000000 -0300
+++ gdb.git/gdb/breakpoint.c	2011-04-08 16:23:24.000000000 -0300
@@ -12337,7 +12337,7 @@ save_breakpoints (char *filename, int fr
     if (filter && !filter (tp))
       continue;
 
-    if (tp->ops != NULL)
+    if (tp->ops != NULL && tp->ops->print_recreate != NULL)
       (tp->ops->print_recreate) (tp, fp);
     else
       {



             reply	other threads:[~2011-04-08 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 20:42 Thiago Jung Bauermann [this message]
2011-04-12 11:04 ` Pedro Alves
2011-04-13 18:34   ` Thiago Jung Bauermann
2011-04-14 11:49     ` Joel Brobecker
2011-04-15  4:19       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302295317.2074.9.camel@hactar \
    --to=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox