From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5899 invoked by alias); 31 Mar 2011 15:03:42 -0000 Received: (qmail 5887 invoked by uid 22791); 31 Mar 2011 15:03:41 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MAY_BE_FORGED,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Mar 2011 15:03:36 +0000 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2VEpdGg018478 for ; Thu, 31 Mar 2011 08:51:39 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p2VF3VYf084012 for ; Thu, 31 Mar 2011 09:03:32 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2VF3OS2022578 for ; Thu, 31 Mar 2011 09:03:26 -0600 Received: from [9.18.235.101] (dyn531364.br.ibm.com [9.18.235.101] (may be forged)) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p2VF3MEe022209; Thu, 31 Mar 2011 09:03:23 -0600 Subject: Re: [RFA] Implement support for PowerPC BookE ranged breakpoints From: Thiago Jung Bauermann To: Ulrich Weigand Cc: gdb-patches ml In-Reply-To: <1301582761.9154.14.camel@hactar> References: <201103291223.p2TCNd58027043@d06av02.portsmouth.uk.ibm.com> <1301582761.9154.14.camel@hactar> Content-Type: text/plain; charset="UTF-8" Date: Thu, 31 Mar 2011 16:04:00 -0000 Message-ID: <1301583801.9154.16.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01218.txt.bz2 On Thu, 2011-03-31 at 11:46 -0300, Thiago Jung Bauermann wrote: > On Tue, 2011-03-29 at 14:23 +0200, Ulrich Weigand wrote: > > Thiago Jung Bauermann wrote: > > > + /* We call decode_line_n1 directly here instead of using > > > > Typo: decode_line_1 > > Doh, forgot to fix that one in my commit. Will do in a moment. Committed the following. -- []'s Thiago Jung Bauermann IBM Linux Technology Center 2011-03-31 Thiago Jung Bauermann * breakpoint.c (break_range_command): Fix typo in comment. Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.560 diff -u -r1.560 breakpoint.c --- breakpoint.c 31 Mar 2011 14:32:48 -0000 1.560 +++ breakpoint.c 31 Mar 2011 15:00:17 -0000 @@ -8594,7 +8594,7 @@ init_linespec_result (&canonical_end); arg_start = arg; - /* We call decode_line_n1 directly here instead of using + /* We call decode_line_1 directly here instead of using parse_breakpoint_sals because we need to specify the start location's symtab and line as the default symtab and line for the end of the range. This makes it possible to have ranges like "foo.c:27, +14",