Re: [rfc] More intelligent indenting of multi-line table entries (Re: [RFA] Implement support for PowerPC BookE ranged breakpoin

Ulrich Weigand
2011-02-28T15:23:24Z

Pedro Alves wrote:
> On Thursday 24 February 2011 20:41:12, Ulrich Weigand wrote:
> > My thought was to remove that redundancy completely, and simply
> > ask the UI table layer for the correct position. It turns out
> > that this needs some new functionality exported from that layer,
> > but a simply query for the field information you originally
> > passed to that layer suffices.
> >=20
> > The following patch implements this suggestion; it fixes the currently
> > broken indentation and gets rid of the silly arguments to the
> > print_breakpoint_location function.
> >=20
> > Tested on i386-linux and by manual inspection of line wrapping.
> >=20
> > Any comments?
>
> Looks great to me.

Thanks for the review! I've checked this in now.

> I've mentioned this before, but I think it'd really be nice
> that the table layout support was reworked to be able to auto
> wrap (and size perhaps) columns nicely, =E0 la emacs' org-mode,
> vis:
>
> | Num | Name | What | Other column |
> |-----+--------------+----------+--------------|
> | 1 | foo bar | foo | another |
> | | | bar what | broken |
> | | | | sentence |
> |-----+--------------+----------+--------------|
> | 2 | the other | what? | yummy |
>
> so that all colums would line-break nicely without
> messing their rightmost columns. (without the guide
> lines, of course).

Yes, ideally the UI table mode should really automatically
lay out the full table. But right now it seems to be used
interspersed with regular output commands, so getting there
would probably require major changes to the current output
generators ...

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com