From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bpwNMIqQdWquCxAAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 04:00:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fLPQfnv0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PokMgC3I; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sF0mjK+A; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wpaFxbHA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B10361E033; Fri, 07 Aug 2026 04:00:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A18F61E033 for ; Fri, 07 Aug 2026 04:00:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2EBEC4BB5886 for ; Fri, 7 Aug 2026 08:00:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2EBEC4BB5886 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fLPQfnv0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PokMgC3I; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sF0mjK+A; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wpaFxbHA Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id C42514BA79AE for ; Fri, 7 Aug 2026 07:59:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C42514BA79AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C42514BA79AE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786089583; cv=none; b=ZesCXPu/j9uuUg24LeJ64dh9O7oidEuKZ2hAupG/6MCC5xvA4q2/fbA/+nJQj9NvYAi/w0glEHZCJGUkWzi70GGjEV+KaFfEAFuMOaCU3/fPi3dGiiTmZtTjtLP4F78U76SSzdBxus0m6LFHuLTgXQ4i+GtHAzPtpHFUfvbjXKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786089583; c=relaxed/simple; bh=086jCOkZwG6R/N4gjqgGTh2VWA/nQVznS+Td0fZB3k4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=mKhohW5C+tzkjc6uL5yaN20niOGB9CSApHKSq25gwqf/61o37YTIAD73ahO15o3p2Us8GpMOhqavCa7sYXAkswW0rMj6HFKx8xjMTq2CWPse7J92H1bqyd3Gojwp/8atDS778FYUyXtpMsoCrOt41rpQoZ4bqQk9E2rNj1oYQmM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fLPQfnv0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=PokMgC3I; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=sF0mjK+A; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wpaFxbHA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C42514BA79AE Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 98998804B9; Fri, 7 Aug 2026 07:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786089578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3MeY2DZKXcYzEXAEatumcMpLIYOOqaopz1FvjV91aY=; b=fLPQfnv0ni/mVOUoAoWuJVnwwApC0au0WzuLgT4VY/49tKTXyl+8k0THfc02FZSLJzTgv1 WYnOjJ1gJ5icNA3YUB8jue9Mirnj2+sPEIh9uZPFDG5aBx1BRYE77EF72Mk77hnu3YwlKW 86JIjBzruWXzs+Of+he9s+t0+dVcvZs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786089578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3MeY2DZKXcYzEXAEatumcMpLIYOOqaopz1FvjV91aY=; b=PokMgC3I0+E64GAxayDTZf5rxY6XK9e2u42JXwZiUmVyyNPJm6uW3URBIIUKBEAbxmj1iL tE1DKjS9T59I4kDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786089574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3MeY2DZKXcYzEXAEatumcMpLIYOOqaopz1FvjV91aY=; b=sF0mjK+AzfZX/nL1LH/cgw3AyEHnBaM75NLfORo6znZbwigD9mAJDBHLcCM6VK3Xq39j4G aNtdeznZAZnLuopLt3mU6GM+6jFaf+fiUIjHUvCdURSm7ts+AmXBKMIXf7nLF4x15IY3T6 SJoHrqHAEdblrN4EKpqo7swtnXUuC+U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786089574; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3MeY2DZKXcYzEXAEatumcMpLIYOOqaopz1FvjV91aY=; b=wpaFxbHAlHmIHqPj2EVl4OqFiIEIAOFFv7AJZYZDWOWTHN0LWGvkN9VVbTI5ljnSv4jQtu CgeWn305mgQ+csDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7B2DA779B6; Fri, 7 Aug 2026 07:59:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WFNwHGaQdWr/LwAAD6G6ig (envelope-from ); Fri, 07 Aug 2026 07:59:34 +0000 Message-ID: <12d8866c-3969-4be2-92af-1fefa28f6373@suse.de> Date: Fri, 7 Aug 2026 09:59:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: use inferior::threads instead of all_threads and a PID filter To: Andrew Burgess , gdb-patches@sourceware.org References: <2dbabbed902e38a1d4534fd7ecd3362331f71ea8.1786049312.git.aburgess@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <2dbabbed902e38a1d4534fd7ecd3362331f71ea8.1786049312.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/6/26 10:54 PM, Andrew Burgess wrote: > I noticed a few places where we iterated over `all_threads ()` but > then immediately filtered by PID. It would be better to instead > iterate over `inferior::threads ()` and remove the PID filtering. > > These should be equivalent as a single inferior should contain every > thread with a given PID, and should only contain threads with that > given PID. > > While editing the `for (...)` loops I have replaced 'auto' with > 'thread_info' for additional type clarity. > > There should be no user visible changes after this commit. Hi Andrew, this LGTM. FWIW, I had a Claude Code session review this, and I asked it to find other locations in need of the same treatment, and it found sync_threadlists in gdb/aix-thread.c, where we can replace all_threads_safe with inferior::threads_safe (). But that requires testing on AIX, so I suppose it's not something that is easily added to this patch. Approved-By: Tom de Vries Thanks, - Tom > --- > gdb/mi/mi-main.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c > index 8b6da41ffeb..903c6a5f411 100644 > --- a/gdb/mi/mi-main.c > +++ b/gdb/mi/mi-main.c > @@ -359,14 +359,11 @@ mi_cmd_exec_interrupt (const char *command, const char *const *argv, int argc) > scoped_disable_commit_resumed disable_commit_resumed > ("interrupting all threads of thread group"); > > - for (auto &thread : all_threads ()) > + for (thread_info &thread : inf->threads ()) > { > if (thread.state () != THREAD_RUNNING) > continue; > > - if (thread.ptid.pid () != inf->pid) > - continue; > - > target_stop (thread.ptid); > } > } > @@ -603,14 +600,13 @@ print_one_inferior (struct inferior *inferior, bool recurse, > > if (inferior->pid != 0) > { > - for (auto &ti : all_threads ()) > - if (ti.ptid.pid () == inferior->pid) > - { > - int core = target_core_of_thread (ti.ptid); > + for (thread_info &ti : inferior->threads ()) > + { > + int core = target_core_of_thread (ti.ptid); > > - if (core != -1) > - cores.insert (core); > - } > + if (core != -1) > + cores.insert (core); > + } > } > > if (!cores.empty ())