From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id odLsMcptZ2qgQDAAWB0awg (envelope-from ) for ; Mon, 27 Jul 2026 10:40:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=LOxyx45C; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=LOxyx45C; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C830F1E099; Mon, 27 Jul 2026 10:40:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 514E41E099 for ; Mon, 27 Jul 2026 10:40:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD8CA4BB1C1D for ; Mon, 27 Jul 2026 14:40:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD8CA4BB1C1D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=LOxyx45C; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=LOxyx45C Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20f::7]) by sourceware.org (Postfix) with ESMTPS id C2F824BAE7E6 for ; Mon, 27 Jul 2026 14:39:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2F824BAE7E6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2F824BAE7E6 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20f::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785163183; cv=pass; b=w+dBPBT0xHEnFbeuO79B8BUPmYksEFzHdUZL9Dcf26dSQX+wEKEohAkgfCBPvgKF5v34S8vO+ezZtl7JvQM7ZD76Id9D12l8jTKp5WyNjbnehf2LRTFBfpy90IgFqTDVFATsXIoEZYzU6GiBcejilx6D503PKaK1o8TpTKXXWUc= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1785163183; c=relaxed/simple; bh=yPIX6Bbk3kP7ccnA5LzwzjcSKR7g5iH28qNjbAo5FXc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=EcpWZNbnWhkhuxCzvr3NSXNDt/C9lauMpt0PB0tFTh04VU1JyL7xg/M9HA/UppNSmghSTJQrBSJ8KKZUiNDxTbmUPKJoO+FgZmSggdXeg9eUFJwvajYtht9EB/pRWhfMZ00ofkwTUYcy1JRkDltpgxbfbwxqzxi2RMxi0OGfTVE= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=LOxyx45C; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=LOxyx45C DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2F824BAE7E6 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=d6s6ZEYOJ7/IpnhQ2+Fo6jcntRtKjmK5PEDKVKF17JtLeE9QRobXkZwNzq/2WN9u98ZF5RCmyRgMpU6D/BNQQSn6qG7boJtLNf8Ue92nYnOu7yMIMuJTkrNGJaridtuZEgE9ZQN4O749wTo3rUObKP+CWbs3lFThEYpy/eOMmikZzSHJZ3XEl7HS2CipWDRDpB20dRuVWXwwks7hFxATrYvqnyVe/XEeqybqDKBkNUMaHAV5+vtr5RwS2mrhxsw30EeWB/Tdr0/sjf4T6FpIU8KHcgnHPXx3m9XrKcZwg0tZVZqjpkNQm/9JymyexXXDOCiSgXptBK5eOiqUWARD0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4JTHscq5L0mxtUcuF9zitKEDFdZOInIGIpsmtqYTgv0=; b=khejLTgejoM5TXO67JFB25a9dOwWE0Nl0DzUJWHwKurHb6CmeLRKHOAWzAiF/rkUUBvQEEDXiORueEeefaBjLnE+pM26nun1YtDp9HZVgRSQSFE6CB54RlrCGsIZggTitrAmrtfulZivagpGzhdi/Tbpb53bUx1IjtHHg6GjNrWOx+kTzRpYP/Oj1ajhrV7rwkrNE90LNvat7Qc5Ova6dlcS85I2F6Hc/mRh6erFuDka2Oc0vVClU1w63FBYrUAuvSNuvluQ13iumpmgXjBtdsDpua/Z4KFAgue8mBQ/HCAjJYzrPbPK1hxXgXgS6IQ/8bGtxjXxe26BkHzbt1//ew== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JTHscq5L0mxtUcuF9zitKEDFdZOInIGIpsmtqYTgv0=; b=LOxyx45C1wnzVYNg5XtPIlapir7VP6H9ItKSp0aMlWzMKBhLLxuyOZ5lR6OJ5XXik0mB0v7iBCnFLO12P9rvEKzXaosNSazn+VXYYmHVctg3P/etQy2qGEijCRuGsFNkCCytg7d11yskIia/zZUuPSKKXJ5HjxG0tGt6BcS85ec= Received: from AS9PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:20b:462::10) by AS8PR08MB7944.eurprd08.prod.outlook.com (2603:10a6:20b:541::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Mon, 27 Jul 2026 14:39:33 +0000 Received: from AM4PEPF00027A63.eurprd04.prod.outlook.com (2603:10a6:20b:462:cafe::1a) by AS9PR06CA0011.outlook.office365.com (2603:10a6:20b:462::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.13 via Frontend Transport; Mon, 27 Jul 2026 14:39:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM4PEPF00027A63.mail.protection.outlook.com (10.167.16.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Mon, 27 Jul 2026 14:39:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V6yAXr6CoMsSjQy7X/MHnmJCOQFdp0tTQ8FcZCFU20Ys2WOv0MNyeEg5Px8KphkGWCMw06iN0EwXPWCGpkaYngs5lClK6ll8r2mZo334FJXmafuwleQV5DmsKYA2iZHXiwrMKBxGI9z68QGjAl0uMqLj7qkPyIrF/m37wCMErCJF+ylU1tQVEF6ptrCWp0VywrYW5p1fY4A3ZZ4iqXiqGX65srCOr0kuhC1E9Mbt4bfWpqF/ou7FcLsgc9nO4XgSOynjFEH+8q9TxyizUJzcmXwfcwdYRqCEiqAmJPWgqT2A8jbRbCD2qSXWaXZsquCFqxLj/ciDlHo0JdKaIsFXZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4JTHscq5L0mxtUcuF9zitKEDFdZOInIGIpsmtqYTgv0=; b=eCyEOkAF16RghMWjkvaSC9x1aXh3ohRmXvOgJeugtceiOEPREYhfI5ClGNc2KYmEj60hY3lHqh5a9+nc5Iit2p/caBWP102ejnlMgrCjnANdYF4OumubD/EHu8fn3IhWke6094MSQzV+T/PsMZ0xlQEuJ1D9AcfjwQD6hgAfkAg6LeVVCKI8E1tNILevG7xTJIWwzWZq2nx0yrrq1PJugTcESnE8LHXVUyNhl27arWDWT9ypMA9AbdcQx+/WH0OqPn3xyKkZp8yDYWy4kZbuT9NwH066G/Jmx6by9cdEyhkrG2XRnZ/zkFWoK2T5UFnxEvhqvpnxNtd1GnHVkbc8mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JTHscq5L0mxtUcuF9zitKEDFdZOInIGIpsmtqYTgv0=; b=LOxyx45C1wnzVYNg5XtPIlapir7VP6H9ItKSp0aMlWzMKBhLLxuyOZ5lR6OJ5XXik0mB0v7iBCnFLO12P9rvEKzXaosNSazn+VXYYmHVctg3P/etQy2qGEijCRuGsFNkCCytg7d11yskIia/zZUuPSKKXJ5HjxG0tGt6BcS85ec= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) by AS2PR08MB10178.eurprd08.prod.outlook.com (2603:10a6:20b:64c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.13; Mon, 27 Jul 2026 14:38:28 +0000 Received: from AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae]) by AS8PR08MB8659.eurprd08.prod.outlook.com ([fe80::96bf:2de3:5eab:70ae%5]) with mapi id 15.21.0245.012; Mon, 27 Jul 2026 14:38:27 +0000 Message-ID: <12b67d75-7d0f-43a7-8596-393aeab2c7cb@arm.com> Date: Mon, 27 Jul 2026 15:38:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/10] gdb/linux-tdep: change linux_fill_prpsinfo to return bool To: "gdb-patches@sourceware.org" Cc: Simon Marchi , Thiago Jung Bauermann References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-2-matthieu.longo@arm.com> <87se5s1xxf.fsf@linaro.org> <400ce145-7dbf-4e4a-a681-48ca86cf874e@simark.ca> Content-Language: en-US From: Matthieu Longo In-Reply-To: <400ce145-7dbf-4e4a-a681-48ca86cf874e@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0500.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::7) To AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB8659:EE_|AS2PR08MB10178:EE_|AM4PEPF00027A63:EE_|AS8PR08MB7944:EE_ X-MS-Office365-Filtering-Correlation-Id: ddb0c4fd-30ac-48a0-4d91-08deebecdf15 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|366016|1800799024|23010399003|376014|11063799006|10067099003|56012099006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: pyRPEfP5u20nrl+fgULp2cco/oTqpU4dLaV8J8lU1kO/v37yTawkYtGOKKiQobJ4mmsJxGhqkf4GPJjjAQ3uaU/O33PsqsqbwcWgPNw93nQY/ELKQWrstVUrWoX2XhsdnN03L8m7YVWaSqwOI5K4eJ+Gvr8UN/4VzrvEJY8NY65NqCbjNMl+clJTCPQvR8gVWY8fXdEfYFQMdHrIT8hZTsq3458O5L0iXFdNVRvoLy/AMsqcNG6aCHxal65qEj9yIMYwIVL/T/NipQ+RjERRaBOnVW5Ir13327glnATQSb4PxL+KpVXdzJZ5vv+sq1RsX08Y5hkAkGjMezbephsJK1ueyNMLgJHB3Ifbc1SNU/eF3gPBUN+4HxY+mLdFyS2TmndBhaaW2RuGlSeRr9FAbOzyvJb1L+HT7u8ZLATGaCK5byivvbkYbTYB4LjPkNzjDlxWg49VpAWz/r9Tkd8H9taSmKXbyD9ZSssRWYqGa/E9T5AQweQqVGoYv3xIdI4p3ejByCQGt22l2obGtMidpEA7dDcbH86q4MCqwgJp+/JICZ4jW7uOWCK77l5PCcuaPmmrUif7FsI+mv/khkZpHAdACihYgdsfOJqD9wlbW7A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB8659.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(11063799006)(10067099003)(56012099006)(4143699003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: abonXEE60HEaslWihSFTwOC39Wg/kZdwYgKyPdU95b831jn5hpy3pbW/Wv65i7QhWpaeJKupoY+/tGMpIUPm1BbAHdzzJVEGEcemG9eBVqNhhmVo72k5eB+cfHeNU9NCNkBSQtbGvw3gMj3vEsuViGZfRo6YTSCj7yCgjvhnKja2RiBWH8hdbNrwwAXLsxKKAODfV2Fv0Rmrbv1/MYWh3ldKTA1rs83Ghp2Z1FWvF6dK3Mcf/C0+Nc8aMib856eXUVn1eIzAEaeqeo/Tdfuo3iDldKJpqzeNxiANGwHEylcj1vsyxn9CIgnyip1FiUeJKqU7btWfo61GQ3TLEr+Vug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10178 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A63.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e09734b7-8af2-4cea-3091-08deebecb878 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|14060799003|23010399003|35042699022|36860700016|376014|82310400026|10067099003|11063799006|4143699003|56012099006|22082099003|18002099003|13003099007; X-Microsoft-Antispam-Message-Info: KswSSK0QYF2AHZt29RWIrP1pKpor1rm4IOI6BxApex88/X8TdetkOaXV+jTzPzntpmT7BL+1LfwVwfOio7N0P+U36Dxx/y9Kzuvj2C02/yBjIVUAjVrOP4mSddso32ZN96deN5S/WPYq7A5mJD5yigeaTKwVGGNK8tfofZXu5mgR4aHp5fb7fj7YhuwJ84GMkL46/kjY9Tp7vttj2Nj68L9lqUIniXbDBzV3m7clJkWCISsuDY8NvxEcx9ozOdopnV32s41kPHHl5FzK69gxNe/05srY9PU1Xwfx68AqaQXxrocuQQGoG23zHqrzSeOaBN7rUUGPvEgy4tUyy3IQou2L3GFVNo2E30AO3zmQSgOJGBEsbtYKC6rYx0fXARAqcUPdtXWFaOiOipca9GcLvS3B8MZ0+03MPfbgEX+XhCOV7oLXs0xAuAXORoaFYF34cxgwsEv21AlmghWrv7/AQ8xr1UbaRnfDNZza3fmTYFTznetj4hR1UEP0TiER1bozwb0DrfOfpwB0q5NYQzUnKkt+3a8uLarYypvVTKkOdQveJPbtXmlDx4rb8fbiK37CC3Uiwm4qhwVdtvc9jdbWhvil93jxDlh9gjG4yu2n++ccTSx0bKufK8ns36Yvy1icP+8pmyMCsYifXUZ3yLGb9A== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(14060799003)(23010399003)(35042699022)(36860700016)(376014)(82310400026)(10067099003)(11063799006)(4143699003)(56012099006)(22082099003)(18002099003)(13003099007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nMZpXcUwhbAfQ7nTykkSmzlec7gG6xjAj/zLupjPElrGatHuo24bHTK8I/NYwvfkxqboJG8hHUT8GXXAvYP08zMyJblQpFGe9u7yuZKFFqy8T23V0ZB14vSUeSioV2wp1QyLogj2NYDPlFihPeCrQY/dfzwQBM6OdqTJlB57MYejzPYBZmrAVaTDUa2/7tsgTLHFf1PBwY1Y/OtqmtF+77uhl8WhisUp8rVQouBzRrOYx9GfH8S11bygLMqRmidgKIy8zaQ0xYfxhl8y5a55jb/CKYoBr2oN7KXY6Hezbyisa9xQ0YY5VrkHfjywFdOuMCpVR+Q1PTQvzX6ZShZSGWOC4zn9f9BEGI+wjrYdVGw4EGhx2f2F7nP9vUo4jOvZKIoteT0eEmsDJVzZRjTsNiJ2IQ54DTUzHPbzUxfVhEELYuBN/9VrqTPHgEpg6c/4 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2026 14:39:31.9451 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ddb0c4fd-30ac-48a0-4d91-08deebecdf15 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A63.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7944 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 09/07/2026 13:23, Simon Marchi wrote: > > > On 2026-07-09 02:26, Thiago Jung Bauermann wrote: >> Hello Matthieu, >> >> Thank you for these patches. >> >> Matthieu Longo writes: >> >>> Change linux_fill_prpsinfo() to return a boolean instead of an integer, since >>> it only reports success or failure. >>> Replace the returned integer values 1 and 0 with true and false respectively. >>> --- >>> gdb/linux-tdep.c | 22 +++++++++++----------- >>> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> In his review of an analogous patch, Simon suggested that this kind of >> change could be pushed as obvious: >> >> https://inbox.sourceware.org/gdb-patches/53a86cae-2927-49ec-83a2-22ff6526c0e6@simark.ca/ >> >> I would agree, but I don't know if that's a generally accepted view. > > Yeah, you still need to be careful, I did manage once to mess up and > change a 0 into true or vice versa. > > Also, try to change comments that use 0/1, or "zero"/"non-zero" so they > say true/false. I see you did it for comments inside the function, but > the comment above the function also has thing that would need to be > updated. > >> >> In any case: >> >> Reviewed-by: Thiago Jung Bauermann > > With the comment updated: > > Approved-By: Simon Marchi > > Simon Merged. https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=067cdb3b087a78820e2e71ae5e7f7de7763712d5 Matthieu