From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YFrcCc17nmGXYAAAWB0awg (envelope-from ) for ; Wed, 24 Nov 2021 12:52:13 -0500 Received: by simark.ca (Postfix, from userid 112) id 21CA31F0CE; Wed, 24 Nov 2021 12:52:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC3FC1E940 for ; Wed, 24 Nov 2021 12:52:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FF963857813 for ; Wed, 24 Nov 2021 17:52:12 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 3AB70385803A for ; Wed, 24 Nov 2021 17:51:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AB70385803A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 01FD585D24; Wed, 24 Nov 2021 17:51:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzpVL4726z3FlG; Wed, 24 Nov 2021 17:51:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id D2EA4C97; Wed, 24 Nov 2021 17:51:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <12ab89ab-e908-346c-d67f-86a663b785d0@FreeBSD.org> Date: Wed, 24 Nov 2021 09:51:52 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] gdb fix for catch-syscall.exp Content-Language: en-US To: Carl Love , Simon Marchi , gdb-patches@sourceware.org References: <3b8e450b9fb4f4bec97a6bfbe6e6a4816be780ee.camel@us.ibm.com> <4d51616392553dd308672f65f18909ebf0513fc0.camel@us.ibm.com> <95fbffc3-8d30-6e75-4f52-f6e534a13b20@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637776314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nssjPeqbH7Bk7ApN2EL8+7FbnSe1bSSB36Z29bwPYqE=; b=IXl7Dd79ZeJQ1nJCBQxl8E6mZDJH72+MdCPhxfk/bRS/BLp7wWp8PvXvnOBafkWfIVgXdp 54/giVoaQ0J51KOfYcVGk5Vx5fBhB0WS28HrAW57mg2GvCdvYAS2mUmXk7b4su7lnzACBj PqcPppYHw+C7pdElKlHQ1Jp8fYNa69lbNIvG5QfapKCkWnJgwOilzkbk6/cxaRZV9hZIqI qeeUggjKEzj0qCEv6x8+PVlOQofwksY8drmDjivg0upu4vfY3XKngpD9FTojm9CgOrYcut oBGDDJgDR2QhjU+5sS3WxYcAXBknAbleWDM9gE/Gf5HJGwGcUsQVw+L3d0/hVQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637776314; a=rsa-sha256; cv=none; b=Nby6XKUzLL/Whqfmna/h7rWlb65fNYzZjK/48FOV00v40LNTbZnqVIuJ4UbHdQEOTvVQJl fO2OX9FOo5cvvNBNj1xKvBhKag5o2QOcneLFKJDSGPrg+dUfLnKAg5GHsAfjYvdQLKGXom RIweBviAfuqzWp5CVEWrCXwcgPt1uYDFeD4jnyQVZNXxscag+HdxeK95JjaVihaU30P4Zi igCUPD3QqsYMxPngPaglH6JlqChOMa1jip/wKoAi3L1dEbZr2OX9Pj14JiGmGcogT1rs+k 4v6NlNNlj7PJKCyr88CCnMcC+9XRzzpK88Wrc3no13mfTzfGiT+cGgZJe73qgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rogerio Alves Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 11/24/21 9:46 AM, Carl Love wrote: > On Tue, 2021-11-23 at 14:34 -0800, John Baldwin wrote: >>>> > > > >> On 11/23/21 12:34 PM, Simon Marchi wrote: >>> >>> The behavior on powerpc sounds like a bug to me, and adjusting the >>> test >>> like this patch did just covers it up. It doesn't make sense for >>> that >>> behavior to be different per arch, for the same OS. >>> >>> If you all agree that it's a bug, I would suggest reverting this >>> patch >>> and making a patch that kfails the test when on powerpc. And >>> ideally, >>> someone should dig to understand why we don't see the return on >>> powerpc >>> (and fix it), but I'm not here to tell what other people should >>> work on >>> :). >> >> I do think this is likely a kernel bug. In FreeBSD's case we report >> a single >> event for both the syscall exit and exec event (but set flags to >> indicate that >> both events are present.. in practice for GDB I think this means that >> on >> FreeBSD we only report the exec event. Not sure if it would be more >> correct >> to report two events to the core in that case.) I do think that a >> given OS >> should probably be consistent here across architectures. >> > > So I sent out a preliminary patch for comments to revert the change and > make it an xfail. For GDB I think you have to make it an xfail for powerpc. > I was looking to see where I should file a bug. The discussion has > said it is a kernel bug. The Freebsd commit you pointed to is a distro > fix from what I can see? So, is it really a linux kernel issue or > something that the distros handle? I believe there is a ptrace code in > glib see that interacts with the result from the kernel, is that where > the fix should go to fix all arch? The FreeBSD commit isn't for a distro, it's for a different OS kernel that supports (some) Linux binaries as an alternate userspace ABI. For the kernel bug you would need to file that with the Linux kernel maintainers following the directions at https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html -- John Baldwin