Tom Tromey wrote: > Simon -- I can't readily try this patch on macOS right now, so I was > hoping you could. I have independently done the same bisection as in gdb/24060 (should have looked at the list archives more carefully first!), and can confirm that this patch fixes c-exp.y. However the same problem occurs for f-exp.y (and perhaps others). John From gdb-patches-return-153239-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jan 07 15:40:37 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 13692 invoked by alias); 7 Jan 2019 15:40:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 13677 invoked by uid 89); 7 Jan 2019 15:40:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 testsºYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1388, closely X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.168.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 15:40:34 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id ACEAAA133 for ; Mon, 7 Jan 2019 09:40:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gX0zgXtYd2PzOgX0zgCrog; Mon, 07 Jan 2019 09:40:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; sÞfault; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DGv+TAazXGj19YQ8KHykq7Dw8BHJF/sSjflJ5IbrfcI=; b=yEzKcbafOZ0o1pCcMkVX4HrRDH y48nq9/uWpGi04wKIHhw4EAUaKkWNaon/ui7ODjjOdczcil6YBTAU8XmvTMwfgdKCzgb2hFj//x62 Flab+bM21mVKfyJBPssfHL1nH; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:50688 heloºpiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ggX0z-001F1n-DM; Mon, 07 Jan 2019 09:40:33 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Replace make_bpstat_clear_actions_cleanup References: <20190107124354.17415-1-andrew.burgess@embecosm.com> Date: Mon, 07 Jan 2019 15:40:00 -0000 In-Reply-To: <20190107124354.17415-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Mon, 7 Jan 2019 12:43:54 +0000") Message-ID: <87zhsczdan.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00129.txt.bz2 Content-length: 1345 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Replace make_bpstat_clear_actions_cleanup with a new class that can Andrew> perform the cleanup. Andrew> gdb/ChangeLog: Andrew> * breakpoint.c (bpstat_clear_actions): Rename to... Andrew> (scoped_bpstat_clear_actions::do_bpstat_clear_actions): ...this. Andrew> (bpstat_do_actions): Switch from using Andrew> make_bpstat_clear_actions_cleanup to use Andrew> scoped_bpstat_clear_actions. Andrew> * breakpoint.h (class scoped_bpstat_clear_actions): New. Andrew> * infrun.c (fetch_inferior_event): Switch from using Andrew> make_bpstat_clear_actions_cleanup to use Andrew> scoped_bpstat_clear_actions. Andrew> * top.c (execute_command): Likewise. Andrew> * utils.c (do_bpstat_clear_actions_cleanup): Delete. Andrew> (make_bpstat_clear_actions_cleanup): Delete. Andrew> * utils.h (make_bpstat_clear_actions_cleanup): Delete. BTW, this is ok. There's no need to wait on some other series that hasn't been sent. Andrew> void Andrew> -bpstat_clear_actions (void) Andrew> +scoped_bpstat_clear_actions::do_bpstat_clear_actions (void) I looked more closely, and this approach is actually a bit more "integrated" (not sure what word to use) than mine, as mine left bpstat_clear_actions as an ordinary function. So perhaps this is a better way to go. Tom