From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [commit/testsuite] small py-breakpoint.exp cleanups
Date: Tue, 22 Feb 2011 16:43:00 -0000 [thread overview]
Message-ID: <1298392978-29062-1-git-send-email-brobecker@adacore.com> (raw)
I looked a bit at this testcase, and notice a few things that were
easy to fix:
- prepare_for_testing already does a clean_restart, so calling
prepare_for_testing just after it was useless. Removed.
- We have a "print result" test whose expected output was "545".
I thought that we could make it safer by integrating the equal
sign in the expected output: " = 545".
- Just a tiny typo in one of the comments.
I also noticed that the test comments are not unique, which is not
a huge issue, but it does make it harder to analyze the results.
But there are so many tests, and I didn't have the time today to
take care of that.
gdb/testsuite/ChangeLog:
* gdb.python/py-breakpoint.exp: Remove unnecessary call to
clean_restart. Be a little stricter in the expected output
for one of the tests. Fix a typo in one of the comments.
Tested on x86_64-linux, checked in.
---
gdb/testsuite/ChangeLog | 6 ++++++
gdb/testsuite/gdb.python/py-breakpoint.exp | 7 ++-----
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 46225c0..5d524d4 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,11 @@
2011-02-22 Joel Brobecker <brobecker@adacore.com>
+ * gdb.python/py-breakpoint.exp: Remove unnecessary call to
+ clean_restart. Be a little stricter in the expected output
+ for one of the tests. Fix a typo in one of the comments.
+
+2011-02-22 Joel Brobecker <brobecker@adacore.com>
+
* gdb.python/py-block.exp: Simplify using prepare_for_testing.
Delete variable binfile, no longer use. Add or modify test
comments to make them unique.
diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp
index 6b33284..b9f8c4a 100644
--- a/gdb/testsuite/gdb.python/py-breakpoint.exp
+++ b/gdb/testsuite/gdb.python/py-breakpoint.exp
@@ -28,9 +28,6 @@ if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
return -1
}
-# Start with a fresh gdb.
-clean_restart ${testfile}
-
# Skip all tests if Python scripting is not enabled.
if { [skip_python_tests] } { continue }
@@ -64,7 +61,7 @@ gdb_test "python print blist\[1\].hit_count" "1" "Check breakpoint hit count"
gdb_py_test_silent_cmd "python blist\[1\].ignore_count = 4" "Set breakpoint hit count" 0
gdb_continue_to_breakpoint "Break at multiply."
gdb_test "python print blist\[1\].hit_count" "6" "Check breakpoint hit count"
-gdb_test "print result" "545" "Check expected variable result after 6 iterations"
+gdb_test "print result" " = 545" "Check expected variable result after 6 iterations"
# Test breakpoint is enabled and disabled correctly..
gdb_breakpoint [gdb_get_line_number "Break at add."]
@@ -148,7 +145,7 @@ if ![runto_main] then {
return 0
}
-# Test invisible breakpooints.
+# Test invisible breakpoints.
delete_breakpoints
set ibp_location [gdb_get_line_number "Break at multiply."]
gdb_py_test_silent_cmd "python ibp = gdb.Breakpoint(\"$ibp_location\", internal=False)" "Set invisible breakpoint" 0
--
1.7.1
next reply other threads:[~2011-02-22 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 16:43 Joel Brobecker [this message]
2011-02-22 17:53 ` Tom Tromey
2011-02-23 3:46 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298392978-29062-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox