From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12473 invoked by alias); 7 Feb 2011 13:38:18 -0000 Received: (qmail 12463 invoked by uid 22791); 7 Feb 2011 13:38:17 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Feb 2011 13:38:12 +0000 Received: from /spool/local by e24smtp01.br.ibm.com with XMail ESMTP for from ; Mon, 7 Feb 2011 11:38:08 -0200 Received: from mailhub1.br.ibm.com ([9.18.232.109]) by e24smtp01.br.ibm.com ([10.172.0.143]) with XMail ESMTP; Mon, 7 Feb 2011 11:38:06 -0200 Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p17Dji2Y541174 for ; Mon, 7 Feb 2011 11:45:47 -0200 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p17Dbfwu029987 for ; Mon, 7 Feb 2011 11:37:41 -0200 Received: from [9.78.144.71] ([9.78.144.71]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p17Dbfi5029978; Mon, 7 Feb 2011 11:37:41 -0200 Subject: Re: [RFA] Remove ${objdir} from test messages From: Thiago Jung Bauermann To: Joel Brobecker Cc: gdb-patches ml In-Reply-To: <20110206071636.GO2384@adacore.com> References: <1296857287.3204.10.camel@hactar> <20110206071636.GO2384@adacore.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 Feb 2011 13:38:00 -0000 Message-ID: <1297085859.9710.1.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11020713-6842-0000-0000-00000019646C X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00127.txt.bz2 On Sun, 2011-02-06 at 11:16 +0400, Joel Brobecker wrote: > > 2011-02-04 Thiago Jung Bauermann > > > > * gdb.base/break-interp.exp: Remove ${objdir} from test messages. > > * gdb.base/jit.exp: Likewise. > > * gdb.base/pie-execl.exp: Likewise. > > * gdb.base/solib-nodir.exp: Likewise. > > * gdb.base/solib-overlap.exp: Likewise. > > This is OK. I would have probably done things a little differently, > as I don't think it really matters that the test label says exactly > what command was sent, as long as it's descriptive and unique. So > I would have probably chosen things like "set args $binfile_test"... > But since you've done it this way, no need to spend even more time > on this... I'm not very familiar with the testcases, so I chose to preserve as much of the original output as possible. Thanks for the review! -- []'s Thiago Jung Bauermann IBM Linux Technology Center