From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22570 invoked by alias); 4 Feb 2011 22:09:12 -0000 Received: (qmail 22559 invoked by uid 22791); 4 Feb 2011 22:09:10 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Feb 2011 22:09:04 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with XMail ESMTP for from ; Fri, 4 Feb 2011 20:09:01 -0200 Received: from mailhub1.br.ibm.com ([9.18.232.109]) by e24smtp04.br.ibm.com ([10.172.0.140]) with XMail ESMTP; Fri, 4 Feb 2011 20:08:59 -0200 Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p14MGwsW1073568 for ; Fri, 4 Feb 2011 20:16:58 -0200 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p14M8wlN016077 for ; Fri, 4 Feb 2011 20:08:58 -0200 Received: from [9.8.0.49] ([9.8.0.49]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p14M8v7i015477 for ; Fri, 4 Feb 2011 20:08:57 -0200 Subject: [RFA] Remove ${objdir} from test messages From: Thiago Jung Bauermann To: gdb-patches ml Content-Type: text/plain; charset="UTF-8" Date: Fri, 04 Feb 2011 22:09:00 -0000 Message-ID: <1296857287.3204.10.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11020422-8936-0000-0000-00000067445A X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00099.txt.bz2 Hi, When I compare testsuite results, these messages always stand out even though the tests have the same results, since the build directory is different for each testsuite run. This patch changes the test messages to be constant. Ok? -- []'s Thiago Jung Bauermann IBM Linux Technology Center 2011-02-04 Thiago Jung Bauermann * gdb.base/break-interp.exp: Remove ${objdir} from test messages. * gdb.base/jit.exp: Likewise. * gdb.base/pie-execl.exp: Likewise. * gdb.base/solib-nodir.exp: Likewise. * gdb.base/solib-overlap.exp: Likewise. diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.base/break-interp.exp index 7afd919..3df4dcb 100644 --- a/gdb/testsuite/gdb.base/break-interp.exp +++ b/gdb/testsuite/gdb.base/break-interp.exp @@ -390,7 +390,7 @@ proc test_ld {file ifmain trynosym displacement} { global objdir binfile_test # ld.so needs some executable to run to reach _dl_debug_state. - gdb_test_no_output "set args ${objdir}/${subdir}/$binfile_test" + gdb_test_no_output "set args ${objdir}/${subdir}/$binfile_test" "set args OBJDIR/${subdir}/$binfile_test" } reach "_dl_debug_state" "run" $displacement diff --git a/gdb/testsuite/gdb.base/jit.exp b/gdb/testsuite/gdb.base/jit.exp index 6b232ba..1b731b0 100644 --- a/gdb/testsuite/gdb.base/jit.exp +++ b/gdb/testsuite/gdb.base/jit.exp @@ -43,6 +43,7 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb set solib_testfile "jit-solib" set solib_srcfile "${srcdir}/${subdir}/${solib_testfile}.c" set solib_binfile "${objdir}/${subdir}/${solib_testfile}.so" +set solib_binfile_test_msg "OBJDIR/${subdir}/${solib_testfile}.so" # Note: compiling without debug info: the library goes through symbol # renaming by munging on its symbol table, and that wouldn't work for .debug @@ -53,7 +54,7 @@ if { [gdb_compile_shlib ${solib_srcfile} ${solib_binfile} {-fPIC}] != "" } { } proc one_jit_test {count match_str} { - global verbose testfile solib_binfile pf_prefix + global verbose testfile solib_binfile solib_binfile_test_msg pf_prefix set old_pf_prefix $pf_prefix set pf_prefix "one_jit_test-$count" @@ -75,9 +76,9 @@ proc one_jit_test {count match_str} { # Poke desired values directly into inferior instead of using "set args" # because "set args" does not work under gdbserver. - gdb_test "set var argc = 2" - gdb_test "set var libname = \"$solib_binfile\"" - gdb_test "set var count = $count" + gdb_test_no_output "set var argc = 2" + gdb_test_no_output "set var libname = \"$solib_binfile\"" "set var libname = \"$solib_binfile_test_msg\"" + gdb_test_no_output "set var count = $count" gdb_breakpoint [gdb_get_line_number "break here 1"] gdb_continue_to_breakpoint "break here 1" diff --git a/gdb/testsuite/gdb.base/pie-execl.exp b/gdb/testsuite/gdb.base/pie-execl.exp index c34eb22..122a98b 100644 --- a/gdb/testsuite/gdb.base/pie-execl.exp +++ b/gdb/testsuite/gdb.base/pie-execl.exp @@ -32,6 +32,7 @@ set executable1 ${testfile}1 set executable2 ${testfile}2 set binfile1 ${objdir}/${subdir}/${executable1} set binfile2 ${objdir}/${subdir}/${executable2} +set binfile2_test_msg OBJDIR/${subdir}/${executable2} # Use conditional compilation according to `BIN' as GDB remembers the source # file name of the breakpoint. @@ -44,7 +45,7 @@ if {[build_executable ${testfile}.exp $executable1 $srcfile [concat $opts {addit clean_restart ${executable1} -gdb_test_no_output "set args ${binfile2}" +gdb_test_no_output "set args ${binfile2}" "set args ${binfile2_test_msg}" if ![runto_main] { return -1 diff --git a/gdb/testsuite/gdb.base/solib-nodir.exp b/gdb/testsuite/gdb.base/solib-nodir.exp index be444d3..04b96dc 100644 --- a/gdb/testsuite/gdb.base/solib-nodir.exp +++ b/gdb/testsuite/gdb.base/solib-nodir.exp @@ -44,7 +44,7 @@ clean_restart $executable gdb_load_shlibs ${binlibfile} gdb_test_no_output "set env LD_LIBRARY_PATH=:" -gdb_test "cd ${binlibfiledir}" "Working directory [string_to_regexp ${binlibfiledir}]\\." +gdb_test "cd ${binlibfiledir}" "Working directory [string_to_regexp ${binlibfiledir}]\\." "cd OBJDIR/${subdir}" set test "library loaded" if [runto_main] { diff --git a/gdb/testsuite/gdb.base/solib-overlap.exp b/gdb/testsuite/gdb.base/solib-overlap.exp index 428fa2c..c6a4c43 100644 --- a/gdb/testsuite/gdb.base/solib-overlap.exp +++ b/gdb/testsuite/gdb.base/solib-overlap.exp @@ -60,25 +60,28 @@ foreach prelink_lib1 {0x40000000 0x50000000} { # Library file. set binfile_lib1 ${objdir}/${subdir}/${libname}1-${prelink_lib1}.so + set binfile_lib1_test_msg OBJDIR/${subdir}/${libname}1-${prelink_lib1}.so set binfile_lib2 ${objdir}/${subdir}/${libname}2-${prelink_lib1}.so + set binfile_lib2_test_msg OBJDIR/${subdir}/${libname}2-${prelink_lib1}.so set lib_flags {debug} # Binary file. set binfile_base ${testfile}-${prelink_lib1} set binfile ${objdir}/${subdir}/${binfile_base} + set binfile_test_msg OBJDIR/${subdir}/${binfile_base} set bin_flags [list debug shlib=${binfile_lib1} shlib=${binfile_lib2}] set escapedbinfile [string_to_regexp ${binfile}] if { [gdb_compile_shlib ${srcfile_lib} ${binfile_lib1} $lib_flags] != "" || [gdb_compile_shlib ${srcfile_lib} ${binfile_lib2} $lib_flags] != "" || [gdb_compile ${srcfile} ${binfile} executable $bin_flags] != "" } { - untested "Could not compile ${binfile_lib1}, ${binfile_lib2} or ${binfile}." + untested "Could not compile ${binfile_lib1_test_msg}, ${binfile_lib2_test_msg} or ${binfile_test_msg}." return -1 } if {[catch "system \"prelink -N -r ${prelink_lib1} ${binfile_lib1}\""] != 0 || [catch "system \"prelink -N -r ${prelink_lib2} ${binfile_lib2}\""] != 0} { # Maybe we don't have prelink. - untested "Could not prelink ${binfile_lib1} or ${binfile_lib2}." + untested "Could not prelink ${binfile_lib1_test_msg} or ${binfile_lib2_test_msg}." return -1 } @@ -101,7 +104,7 @@ foreach prelink_lib1 {0x40000000 0x50000000} { if { [gdb_compile_shlib ${srcfile_lib} ${binfile_lib1} $lib_flags] != "" || [gdb_compile_shlib ${srcfile_lib} ${binfile_lib2} $lib_flags] != ""} { - untested "Could not recompile ${binfile_lib1} or ${binfile_lib2}." + untested "Could not recompile ${binfile_lib1_test_msg} or ${binfile_lib2_test_msg}." remote_exec build "kill -9 ${testpid}" return -1 }